Lucene - Core
  1. Lucene - Core
  2. LUCENE-6632

Geo3d: More accurate way of computing circle planes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: modules/spatial
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The Geo3d code that computes circle planes in GeoPath and GeoCircle is less accurate the smaller the circle. There's a better way of computing this.

        Activity

        Hide
        Karl Wright added a comment -

        I will attach a patch later today.

        Show
        Karl Wright added a comment - I will attach a patch later today.
        Hide
        Karl Wright added a comment -

        Patch attached.

        Show
        Karl Wright added a comment - Patch attached.
        Hide
        Karl Wright added a comment -

        David Smiley: Here's the next one to consider.

        Show
        Karl Wright added a comment - David Smiley : Here's the next one to consider.
        Hide
        David Smiley added a comment -

        FYI I have special alerts for any issue posted to modules/spatial, so your issues do not escape my attention

        I looked at the patch. I'm curious; wouldn't "upperPoint" and "lowerPoint" as a pair always be farther away than either of them with "center" (for GeoCircle) or "point" (for GeoPath)?

        Show
        David Smiley added a comment - FYI I have special alerts for any issue posted to modules/spatial, so your issues do not escape my attention I looked at the patch. I'm curious; wouldn't "upperPoint" and "lowerPoint" as a pair always be farther away than either of them with "center" (for GeoCircle) or "point" (for GeoPath)?
        Hide
        Karl Wright added a comment -

        We're interested in distance from the line going through the poles. "upperPoint" is just a certain arc distance from the center, going along a plane that represents a longitudinal slice. "lowerPoint" goes the opposite direction. You really can't tell which is farther from the line going through the poles until you check.

        Show
        Karl Wright added a comment - We're interested in distance from the line going through the poles. "upperPoint" is just a certain arc distance from the center, going along a plane that represents a longitudinal slice. "lowerPoint" goes the opposite direction. You really can't tell which is farther from the line going through the poles until you check.
        Hide
        David Smiley added a comment -

        Ok; I'll commit this patch as-is tonight unless there are objections.

        Show
        David Smiley added a comment - Ok; I'll commit this patch as-is tonight unless there are objections.
        Hide
        ASF subversion and git services added a comment -

        Commit 1688759 from David Smiley in branch 'dev/trunk'
        [ https://svn.apache.org/r1688759 ]

        LUCENE-6632: Geo3D: Compute circle planes more accurately.

        Show
        ASF subversion and git services added a comment - Commit 1688759 from David Smiley in branch 'dev/trunk' [ https://svn.apache.org/r1688759 ] LUCENE-6632 : Geo3D: Compute circle planes more accurately.
        Hide
        ASF subversion and git services added a comment -

        Commit 1688760 from David Smiley in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1688760 ]

        LUCENE-6632: Geo3D: Compute circle planes more accurately.

        Show
        ASF subversion and git services added a comment - Commit 1688760 from David Smiley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1688760 ] LUCENE-6632 : Geo3D: Compute circle planes more accurately.
        Hide
        David Smiley added a comment -

        Thanks Karl.

        Show
        David Smiley added a comment - Thanks Karl.
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            David Smiley
            Reporter:
            Karl Wright
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development