Lucene - Core
  1. Lucene - Core
  2. LUCENE-6618

MmapDirectory checkUnmapSupported is buggy

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      If you ban this by policy, it should return false.

      Instead today all writes will fail by default.

      1. LUCENE-6618.patch
        0.7 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -

        Simple patch. I also removed the builder-like chaining here.

        Show
        Robert Muir added a comment - Simple patch. I also removed the builder-like chaining here.
        Hide
        Uwe Schindler added a comment -

        OK, +1

        After chatting with Robert, I understand now what the problem is: The main reason for the setAccessible is to have the same check as done while executing the unmapping. If you don't do the setAccessible,the reflection works, although it may fail later when doing the unmapping.

        Show
        Uwe Schindler added a comment - OK, +1 After chatting with Robert, I understand now what the problem is: The main reason for the setAccessible is to have the same check as done while executing the unmapping. If you don't do the setAccessible,the reflection works, although it may fail later when doing the unmapping.
        Hide
        ASF subversion and git services added a comment -

        Commit 1695859 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1695859 ]

        LUCENE-6618: MMapDirectory.checkUnmapSupported is buggy

        Show
        ASF subversion and git services added a comment - Commit 1695859 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1695859 ] LUCENE-6618 : MMapDirectory.checkUnmapSupported is buggy
        Hide
        ASF subversion and git services added a comment -

        Commit 1695865 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1695865 ]

        LUCENE-6618: MMapDirectory.checkUnmapSupported is buggy

        Show
        ASF subversion and git services added a comment - Commit 1695865 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1695865 ] LUCENE-6618 : MMapDirectory.checkUnmapSupported is buggy
        Hide
        Michael McCandless added a comment -

        Should we backport this to 5.3.0 for the 2nd RC?

        Show
        Michael McCandless added a comment - Should we backport this to 5.3.0 for the 2nd RC?
        Hide
        Michael McCandless added a comment -

        Reopen for backport to 5.3.0

        Show
        Michael McCandless added a comment - Reopen for backport to 5.3.0
        Hide
        ASF subversion and git services added a comment -

        Commit 1696001 from Michael McCandless in branch 'dev/branches/lucene_solr_5_3'
        [ https://svn.apache.org/r1696001 ]

        LUCENE-6618: MMapDirectory.checkUnmapSupported is buggy

        Show
        ASF subversion and git services added a comment - Commit 1696001 from Michael McCandless in branch 'dev/branches/lucene_solr_5_3' [ https://svn.apache.org/r1696001 ] LUCENE-6618 : MMapDirectory.checkUnmapSupported is buggy
        Hide
        ASF subversion and git services added a comment -

        Commit 1696002 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1696002 ]

        LUCENE-6618: move CHANGES.txt entry

        Show
        ASF subversion and git services added a comment - Commit 1696002 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1696002 ] LUCENE-6618 : move CHANGES.txt entry
        Hide
        ASF subversion and git services added a comment -

        Commit 1696003 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1696003 ]

        LUCENE-6618: move CHANGES.txt entry

        Show
        ASF subversion and git services added a comment - Commit 1696003 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1696003 ] LUCENE-6618 : move CHANGES.txt entry
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development