Lucene - Core
  1. Lucene - Core
  2. LUCENE-6594

Add java.time forbidden-apis to trunk (update to forbiddenapis 2.0)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4, 6.0
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The current version of forbiddenapis misses to add the new java.time APIs of Java 8, Some of the methods use default Locale or default Timezone.

      Until a new version of forbidden-apis is released, I would like to add those APIs to the Trunk (Java 8) base.txt signatures list. We already have some code in trunk using java.time (IndexWriter logging), so we should take care of that.

      1. LUCENE-6594.patch
        6 kB
        Uwe Schindler

        Activity

        Show
        Uwe Schindler added a comment - This is the commit in forbidden-apis: https://github.com/policeman-tools/forbidden-apis/commit/c34a02afcd7856478e9adfd32be2fc5bf82ca268
        Hide
        ASF subversion and git services added a comment -

        Commit 1686537 from Uwe Schindler in branch 'dev/trunk'
        [ https://svn.apache.org/r1686537 ]

        LUCENE-6594: Add missing Java 8 signatures (revert this as soon as forbidden-apis was updated)

        Show
        ASF subversion and git services added a comment - Commit 1686537 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1686537 ] LUCENE-6594 : Add missing Java 8 signatures (revert this as soon as forbidden-apis was updated)
        Hide
        Uwe Schindler added a comment -

        I leave this issue open until forbidden-apis has a new version released!

        Show
        Uwe Schindler added a comment - I leave this issue open until forbidden-apis has a new version released!
        Hide
        Uwe Schindler added a comment - - edited

        Forbidden-Apis 2.0 was released a minute ago. I will provide a patch that reverts the last commit and also cleans up Ant build to use the new "arbitrary ANT resource" feature for signatures.

        https://github.com/policeman-tools/forbidden-apis/wiki/Changes

        This is the major 2.0 release of the forbidden-apis plugin. The main new feature is native support for the Gradle build system (minimum requirement is Gradle 2.3). But also Apache Ant and Apache Maven build systems got improved support: Ant can now load signatures from arbitrary resources by using a new XML element <signatures></signatures> that may contain any valid ANT resource, e.g., ivy's cache-filesets or plain URLs. Apache Maven now supports to load signatures files as artifacts from your repository or Maven Central (new signaturesArtifacts Mojo property).

        Show
        Uwe Schindler added a comment - - edited Forbidden-Apis 2.0 was released a minute ago. I will provide a patch that reverts the last commit and also cleans up Ant build to use the new "arbitrary ANT resource" feature for signatures. https://github.com/policeman-tools/forbidden-apis/wiki/Changes This is the major 2.0 release of the forbidden-apis plugin. The main new feature is native support for the Gradle build system (minimum requirement is Gradle 2.3). But also Apache Ant and Apache Maven build systems got improved support: Ant can now load signatures from arbitrary resources by using a new XML element <signatures></signatures> that may contain any valid ANT resource, e.g., ivy's cache-filesets or plain URLs. Apache Maven now supports to load signatures files as artifacts from your repository or Maven Central (new signaturesArtifacts Mojo property).
        Hide
        Uwe Schindler added a comment -

        Patch.

        Show
        Uwe Schindler added a comment - Patch.
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1706128 from Uwe Schindler in branch 'dev/trunk'
        [ https://svn.apache.org/r1706128 ]

        LUCENE-6594: Update forbiddenapis to 2.0

        Show
        ASF subversion and git services added a comment - Commit 1706128 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1706128 ] LUCENE-6594 : Update forbiddenapis to 2.0
        Hide
        ASF subversion and git services added a comment -

        Commit 1706130 from Uwe Schindler in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1706130 ]

        Merged revision(s) 1706128 from lucene/dev/trunk:
        LUCENE-6594: Update forbiddenapis to 2.0

        Show
        ASF subversion and git services added a comment - Commit 1706130 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1706130 ] Merged revision(s) 1706128 from lucene/dev/trunk: LUCENE-6594 : Update forbiddenapis to 2.0
        Hide
        ASF subversion and git services added a comment -

        Commit 1706131 from Uwe Schindler in branch 'dev/trunk'
        [ https://svn.apache.org/r1706131 ]

        LUCENE-6594: Add missing changes entry

        Show
        ASF subversion and git services added a comment - Commit 1706131 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1706131 ] LUCENE-6594 : Add missing changes entry
        Hide
        ASF subversion and git services added a comment -

        Commit 1706132 from Uwe Schindler in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1706132 ]

        Merged revision(s) 1706131 from lucene/dev/trunk:
        LUCENE-6594: Add missing changes entry

        Show
        ASF subversion and git services added a comment - Commit 1706132 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1706132 ] Merged revision(s) 1706131 from lucene/dev/trunk: LUCENE-6594 : Add missing changes entry
        Hide
        Uwe Schindler added a comment -

        Thanks Robert for review.

        Show
        Uwe Schindler added a comment - Thanks Robert for review.

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development