Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Today we only assert that the incoming argument to writeVLong is non-negative; I think this is quite important and should be a real check?

      1. LUCENE-6591.patch
        1 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Patch.

        I also renamed a private method in DataOutput, and fixed typo in comment.

        Show
        Michael McCandless added a comment - Patch. I also renamed a private method in DataOutput, and fixed typo in comment.
        Hide
        Ryan Ernst added a comment -

        +1

        Show
        Ryan Ernst added a comment - +1
        Hide
        Adrien Grand added a comment -

        +1

        Show
        Adrien Grand added a comment - +1
        Hide
        Robert Muir added a comment -

        Can we please rename the method to something simpler than 'writePossiblyNegativeVLong', like 'writeSignedVLong' ?

        Show
        Robert Muir added a comment - Can we please rename the method to something simpler than 'writePossiblyNegativeVLong', like 'writeSignedVLong' ?
        Hide
        Michael McCandless added a comment -

        I like writeSignedVLong ... I'll rename to that and commit!

        Show
        Michael McCandless added a comment - I like writeSignedVLong ... I'll rename to that and commit!
        Hide
        ASF subversion and git services added a comment -

        Commit 1686487 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1686487 ]

        LUCENE-6591: never write a negative vlong

        Show
        ASF subversion and git services added a comment - Commit 1686487 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1686487 ] LUCENE-6591 : never write a negative vlong
        Hide
        ASF subversion and git services added a comment -

        Commit 1686495 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1686495 ]

        LUCENE-6591: never write a negative vlong

        Show
        ASF subversion and git services added a comment - Commit 1686495 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1686495 ] LUCENE-6591 : never write a negative vlong
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development