Lucene - Core
  1. Lucene - Core
  2. LUCENE-6568

rat-sources-typedef doesn't respect ivy configuration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      rat-sources-typedef invoked as a part of precommit doesn't respect settings in lucene/ivy-settings.xml

        Activity

        Hide
        Ramkumar Aiyengar added a comment -

        This change to common-build.xml seems to have done the trick (and consistent with other such targets)

        -  <target name="rat-sources-typedef" unless="rat.loaded">
        +  <target name="rat-sources-typedef" unless="rat.loaded" depends="ivy-availability-check,ivy-configure">
        

        I am no expert with the build system, so if someone could confirm if this is correct, I can go ahead and commit the change.

        Show
        Ramkumar Aiyengar added a comment - This change to common-build.xml seems to have done the trick (and consistent with other such targets) - <target name= "rat-sources-typedef" unless= "rat.loaded" > + <target name= "rat-sources-typedef" unless= "rat.loaded" depends= "ivy-availability-check,ivy-configure" > I am no expert with the build system, so if someone could confirm if this is correct, I can go ahead and commit the change.
        Hide
        ASF subversion and git services added a comment -

        Commit 1688022 from Ramkumar Aiyengar in branch 'dev/trunk'
        [ https://svn.apache.org/r1688022 ]

        LUCENE-6568: Make rat invocation depend on ivy configuration being set up

        Show
        ASF subversion and git services added a comment - Commit 1688022 from Ramkumar Aiyengar in branch 'dev/trunk' [ https://svn.apache.org/r1688022 ] LUCENE-6568 : Make rat invocation depend on ivy configuration being set up
        Hide
        ASF subversion and git services added a comment -

        Commit 1688023 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1688023 ]

        LUCENE-6568: Make rat invocation depend on ivy configuration being set up

        Show
        ASF subversion and git services added a comment - Commit 1688023 from Ramkumar Aiyengar in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1688023 ] LUCENE-6568 : Make rat invocation depend on ivy configuration being set up
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Ramkumar Aiyengar
            Reporter:
            Ramkumar Aiyengar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development