Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6530

Use Java 7 ProcessBuilder.inheritIO() instead of own ThreadPumper

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
    • Lucene Fields:
      New

      Description

      In some tests wie spawn separate processes (TestIndexWriterOnJRECrash and Solr's IPTables). To capture stdin/stdout/stderr we spawn several threads that pump those to stdout/stderr.

      Since Java 7 there is ProcessBuilder.inheritIO() that does this for us without any additional threads. We should use this instead. Fix is easy, just remove some stuff

      I did the same already for my Codec classloader deadlock test, so this is just a followup for the other tests.

      Patch is attached and can be committed to trunk and 5.x.

        Attachments

        1. LUCENE-6530.patch
          9 kB
          Uwe Schindler
        2. LUCENE-6530.patch
          6 kB
          Uwe Schindler

          Activity

            People

            • Assignee:
              uschindler Uwe Schindler
              Reporter:
              uschindler Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: