Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6507

NativeFSLock.close() can invalidate other locks

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      the lock API in Lucene is super trappy since the lock that we return form this API must first be obtained and if we can't obtain it the lock should not be closed since we might ie. close the underlying channel in the NativeLock case which releases all lock for this file on some operating systems. I think the makeLock method should try to obtain and only return a lock if we successfully obtained it. Not sure if it's possible everywhere but we should at least make the documentation clear here.

        Attachments

        1. LUCENE-6507.patch
          21 kB
          Michael McCandless
        2. LUCENE-6507.patch
          19 kB
          Michael McCandless
        3. LUCENE-6507.patch
          18 kB
          Michael McCandless
        4. LUCENE-6507.patch
          17 kB
          Robert Muir
        5. LUCENE-6507.patch
          17 kB
          Robert Muir
        6. LUCENE-6507.patch
          19 kB
          Robert Muir
        7. LUCENE-6507.patch
          14 kB
          Robert Muir
        8. LUCENE-6507.patch
          14 kB
          Robert Muir
        9. LUCENE-6507.patch
          10 kB
          Simon Willnauer
        10. LUCENE-6507.patch
          5 kB
          Robert Muir
        11. LUCENE-6507.patch
          4 kB
          Robert Muir
        12. LUCENE-6507-410x.patch
          28 kB
          Michael McCandless

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              simonw Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: