Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      As mentioned on LUCENE-6371:

      I've marked the new classes and methods as lucene.experimental, rather than moving to the sandbox - if anyone feels strongly about that, maybe it could be done in a follow up issue.
      

      I feel strongly about this and will do the move.

      1. LUCENE-6489.patch
        139 kB
        Alan Woodward
      2. LUCENE-6489.patch
        0.8 kB
        Alan Woodward
      3. LUCENE-6489.patch
        214 kB
        Alan Woodward

        Activity

        Hide
        Robert Muir added a comment -

        My problem with this stuff can be easily seen at the span-near situation

        • SpanNearQuery has a collectPayloads parameter defaulting to true <-- WTF
        • Yet other code claims SpanNear is broken for payloads, despite the slow default and confusing code, so we have a totally separate SpanNearPayload* stuff <-- WTF

        That screams sandbox.

        Show
        Robert Muir added a comment - My problem with this stuff can be easily seen at the span-near situation SpanNearQuery has a collectPayloads parameter defaulting to true <-- WTF Yet other code claims SpanNear is broken for payloads, despite the slow default and confusing code, so we have a totally separate SpanNearPayload* stuff <-- WTF That screams sandbox.
        Hide
        Alan Woodward added a comment -

        The collectPayloads parameter in SpanNearQuery can be nuked now, I think, as collection depends on the SpanCollector passed in.

        Show
        Alan Woodward added a comment - The collectPayloads parameter in SpanNearQuery can be nuked now, I think, as collection depends on the SpanCollector passed in.
        Hide
        Alan Woodward added a comment -

        Span payloads are a bit nicer now, so I suggest we do the following:

        • PayloadScoreQuery and SpanPayloadCheckQuery move to the queries module
        • PayloadSpanUtil moves to sandbox

        Should they be moved in 5.x as well as trunk?

        Show
        Alan Woodward added a comment - Span payloads are a bit nicer now, so I suggest we do the following: PayloadScoreQuery and SpanPayloadCheckQuery move to the queries module PayloadSpanUtil moves to sandbox Should they be moved in 5.x as well as trunk?
        Hide
        Alan Woodward added a comment -

        Here is a patch that:

        • moves PayloadScoreQuery, SpanPayloadCheckQuery, and the various PayloadFunction implementations to the queries module under org.apache.lucene.queries.payloads
        • moves PayloadSpanUtil and SpanPayloadCollector to sandbox
        Show
        Alan Woodward added a comment - Here is a patch that: moves PayloadScoreQuery, SpanPayloadCheckQuery, and the various PayloadFunction implementations to the queries module under org.apache.lucene.queries.payloads moves PayloadSpanUtil and SpanPayloadCollector to sandbox
        Hide
        Alan Woodward added a comment -

        Patch, this time with everything compiling properly... All tests pass.

        Show
        Alan Woodward added a comment - Patch, this time with everything compiling properly... All tests pass.
        Hide
        David Smiley added a comment -

        I guess if I were to enhance a highlighter to use SpanPayloadCollector, I'd need to make that extension in the sandbox then? Just want to confirm.

        Show
        David Smiley added a comment - I guess if I were to enhance a highlighter to use SpanPayloadCollector, I'd need to make that extension in the sandbox then? Just want to confirm.
        Hide
        Alan Woodward added a comment -

        Or just write another implementation. It's pretty lightweight...

        Show
        Alan Woodward added a comment - Or just write another implementation. It's pretty lightweight...
        Hide
        Alan Woodward added a comment -

        Here's the final patch, after much fighting with svn. Committing shortly.

        Show
        Alan Woodward added a comment - Here's the final patch, after much fighting with svn. Committing shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1703392 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1703392 ]

        LUCENE-6489: Move Payload queries to queries module and PayloadSpanUtil to sandbox

        Show
        ASF subversion and git services added a comment - Commit 1703392 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1703392 ] LUCENE-6489 : Move Payload queries to queries module and PayloadSpanUtil to sandbox
        Hide
        ASF subversion and git services added a comment -

        Commit 1703413 from Alan Woodward in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1703413 ]

        LUCENE-6489: Move Payload queries to queries module and PayloadSpanUtil to sandbox

        Show
        ASF subversion and git services added a comment - Commit 1703413 from Alan Woodward in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1703413 ] LUCENE-6489 : Move Payload queries to queries module and PayloadSpanUtil to sandbox

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development