[LUCENE-6488] HandleTrackingFs leaks files if #onClose throws an exception

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1
• Fix Version/s: 5.2, 5.3, 6.0
• Component/s: modules/test-framework
• Lucene Fields: New, Patch Available
• Assignee: Simon Willnauer
• Reporter: Simon Willnauer
• Created: 18/May/15 07:47
• Updated: 28/Aug/22 14:33
• Resolved: 18/May/15 12:29

Description

if #onClose throws an exception for instance due to an error in #onOpen we leak the filehandle since we don't call super.close(). I ran into this in Elasticsearch tests where files are concurrently deleted and we got a WindowsFS -> LeakFS -> UnixFs. The UnixFS opened the file but by the time WindowsFS tried to read the files metadata it was already deleted causing onOpen to barf and we leaked the file.