Lucene - Core
  1. Lucene - Core
  2. LUCENE-6451

Support non-static methods in the Javascript compiler

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Allow methods such as date.getMonth() or string.getOrdinal() to be added in the same way expression variables are now (forwarded to the bindings for processing). This change will only allow non-static methods that have zero arguments due to current limitations in the architecture, and to keep the change simple.

      1. LUCENE-6451.patch
        7 kB
        Jack Conradson
      2. LUCENE-6451.patch
        6 kB
        Jack Conradson

        Activity

        Hide
        Jack Conradson added a comment -

        Patch attached.

        Show
        Jack Conradson added a comment - Patch attached.
        Hide
        Jack Conradson added a comment -

        Added a comment to clarify a confusing change in the code.

        Added a few extra test cases to ensure mixed casing is allowed in non-static methods.

        Show
        Jack Conradson added a comment - Added a comment to clarify a confusing change in the code. Added a few extra test cases to ensure mixed casing is allowed in non-static methods.
        Hide
        Ryan Ernst added a comment -

        This looks good, thanks for the additional comment and tests. I will commit shortly.

        Show
        Ryan Ernst added a comment - This looks good, thanks for the additional comment and tests. I will commit shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1675926 from Ryan Ernst in branch 'dev/trunk'
        [ https://svn.apache.org/r1675926 ]

        LUCENE-6451: Expressions now support bindings keys that look like zero arg functions

        Show
        ASF subversion and git services added a comment - Commit 1675926 from Ryan Ernst in branch 'dev/trunk' [ https://svn.apache.org/r1675926 ] LUCENE-6451 : Expressions now support bindings keys that look like zero arg functions
        Hide
        ASF subversion and git services added a comment -

        Commit 1675927 from Ryan Ernst in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1675927 ]

        LUCENE-6451: Expressions now support bindings keys that look like zero arg functions (merged r1675926)

        Show
        ASF subversion and git services added a comment - Commit 1675927 from Ryan Ernst in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1675927 ] LUCENE-6451 : Expressions now support bindings keys that look like zero arg functions (merged r1675926)
        Hide
        Ryan Ernst added a comment -

        Thanks Jack!

        Show
        Ryan Ernst added a comment - Thanks Jack!
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Ryan Ernst
            Reporter:
            Jack Conradson
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development