Here is a patch which fixes FilterDirectoryStream to take the filesystem it should filter against and a couple tests for newDirectoryStream with and without a glob.

New patch which fixes the glob test to actually check something, and a wraps the filter passed to newDirectoryStream so globs actually work.

+1

When committing can you make the 'fileSystem' instance variable of Filter(Secure)DirectoryStream final?

Updated patch with hard checks on unboxing. While this technically deviates from some of the APIs, I don't care, this is our tests, and we need to be able to debug them (not return false or no results silently).

I also removed SecureDirectoryStream in these wrappers (its optional anyway, and quite complicated: we don't need any more of that), and fixed the hacky filesystem in TestIOUtils to be well-behaved. I fixed failures in the new tests if it got extrasfs as well.

Commit 1673720 from Robert Muir in branch 'dev/trunk'
[ https://svn.apache.org/r1673720 ]

LUCENE-6424: DirectoryStream doesn't wrap with FilterPath

Commit 1673721 from Robert Muir in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1673721 ]

LUCENE-6424: DirectoryStream doesn't wrap with FilterPath

thanks guys! you should have put all our names on the CHANGES.TXT

Commit 1673783 from Robert Muir in branch 'dev/trunk'
[ https://svn.apache.org/r1673783 ]

LUCENE-6424: fix names in CHANGES

Commit 1673784 from Robert Muir in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1673784 ]

LUCENE-6424: fix names in CHANGES

I fixed this Simon, thanks for tracking this one down!

thx anyway

Bulk close for 5.2.0.