[LUCENE-6418] SpanNot sometimes forgets to call matches() on excl approximation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.2, 6.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 12/Apr/15 14:35
• Updated: 28/Aug/22 14:30
• Resolved: 12/Apr/15 18:29

Description

It happens in both impls, so I think the problem is in NearSpansPayloadOrdered. Maybe atFirstInCurrentDoc gets set without matchStart getting set?

Can be triggered more generally in tests like this:

  @Override
  public int nextStartPosition() throws IOException {
    if (atFirstInCurrentDoc) {
      atFirstInCurrentDoc = false;
      assert matchStart >= 0; // add this assert
      return matchStart;
    }