Lucene - Core
  1. Lucene - Core
  2. LUCENE-6416

BooleanQuery should only extract terms from scoring clauses

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.1, 6.0
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      BooleanQuery should not extract terms from FILTER clauses.

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch.

        Show
        Adrien Grand added a comment - Here is a patch.
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1673120 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1673120 ]

        LUCENE-6416: BooleanQuery.extractTerms now only extracts terms from scoring clauses.

        Show
        ASF subversion and git services added a comment - Commit 1673120 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1673120 ] LUCENE-6416 : BooleanQuery.extractTerms now only extracts terms from scoring clauses.
        Hide
        ASF subversion and git services added a comment -

        Commit 1673122 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1673122 ]

        LUCENE-6416: BooleanQuery.extractTerms now only extracts terms from scoring clauses.

        Show
        ASF subversion and git services added a comment - Commit 1673122 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1673122 ] LUCENE-6416 : BooleanQuery.extractTerms now only extracts terms from scoring clauses.
        Hide
        Mikhail Khludnev added a comment -

        Adrien Grand I don't express a concern, but would you mind to clarify the motivation?

        Show
        Mikhail Khludnev added a comment - Adrien Grand I don't express a concern, but would you mind to clarify the motivation?
        Hide
        Adrien Grand added a comment -

        We have two use-cases for extractTerms today: distributed IDF and highlighting and both of them only care about scoring clauses.

        Also this way it is consistent with FilteredQuery which does not extract terms from the filter.

        Show
        Adrien Grand added a comment - We have two use-cases for extractTerms today: distributed IDF and highlighting and both of them only care about scoring clauses. Also this way it is consistent with FilteredQuery which does not extract terms from the filter.
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development