Lucene - Core
  1. Lucene - Core
  2. LUCENE-6410

Remove unused "reuse" param to Terms.iterator

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Terms.iterator takes a reuse param but no impls in fact reuse it. I think callers can just hang onto a TermsEnum and reuse themselves instead?

      1. LUCENE-6410.patch
        163 kB
        Michael McCandless

        Activity

        Hide
        Robert Muir added a comment -

        +1 !

        Show
        Robert Muir added a comment - +1 !
        Hide
        Michael McCandless added a comment -

        Patch, thank you Don McLean.

        Show
        Michael McCandless added a comment - Patch, thank you Don McLean.
        Hide
        Robert Muir added a comment -

        +1 to the patch

        Show
        Robert Muir added a comment - +1 to the patch
        Hide
        ASF subversion and git services added a comment -

        Commit 1672155 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1672155 ]

        LUCENE-6410: remove unused 'reuse' parameter to Terms.iterator

        Show
        ASF subversion and git services added a comment - Commit 1672155 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1672155 ] LUCENE-6410 : remove unused 'reuse' parameter to Terms.iterator
        Hide
        ASF subversion and git services added a comment -

        Commit 1672165 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1672165 ]

        LUCENE-6410: remove unused 'reuse' parameter to Terms.iterator

        Show
        ASF subversion and git services added a comment - Commit 1672165 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1672165 ] LUCENE-6410 : remove unused 'reuse' parameter to Terms.iterator
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development