Lucene - Core
  1. Lucene - Core
  2. LUCENE-6399

Benchmark's AbstractQueryMaker.resetInputs should call setConfig

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2
    • Component/s: modules/benchmark
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      DocMaker.resetInput() will call setConfig. QueryMaker should too for the same reason – so that it can respond to properties that change per round. DocMaker is concrete but QueryMaker is an interface, but this behavior can be put into AbstractQueryMaker.

      I found this as some benchmarking was driving me crazy as I couldn't get spatial benchmark queries to see changes I had!

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1672742 from David Smiley in branch 'dev/trunk'
        [ https://svn.apache.org/r1672742 ]

        LUCENE-6399: Benchmark's QueryMaker.resetInputs should call setConfig

        Show
        ASF subversion and git services added a comment - Commit 1672742 from David Smiley in branch 'dev/trunk' [ https://svn.apache.org/r1672742 ] LUCENE-6399 : Benchmark's QueryMaker.resetInputs should call setConfig
        Hide
        ASF subversion and git services added a comment -

        Commit 1672744 from David Smiley in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1672744 ]

        LUCENE-6399: Benchmark's QueryMaker.resetInputs should call setConfig

        Show
        ASF subversion and git services added a comment - Commit 1672744 from David Smiley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1672744 ] LUCENE-6399 : Benchmark's QueryMaker.resetInputs should call setConfig
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            David Smiley
            Reporter:
            David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development