Should SpansCell still extend FilterSpans and return always YES? This would avoid reimplementing Spans from scratch?
Definitely not. Its not really filtering the spans at all. it is just a wrapper. if we want a class for wrapping lets do that separately.
It took me some time to compile how FilterSpans.twoPhaseCurrentDocMatches works, with its infinite loop, conditional fallthrough, etc. maybe it could be written in a more straightforward way?
This code is moved verbatim from SpanPositionCheck.PositionCheckSpan here, so it can be reused instead of duplicated. Can we refactor it in a separate issue?
My approach here is just removing complex duplicate code that all does the same thing. I realize its exciting that spans are now "unblocked" after paul's big rework , but we need to tackle things incrementally.