Lucene - Core
  1. Lucene - Core
  2. LUCENE-6378

Fix RuntimeExceptions that are thrown without the root cause

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      In the lucene/solr codebase I can see 15 RuntimeExceptions that are thrown without wrapping the root cause.

      We should fix them to wrap the root cause before throwing it.

      1. LUCENE-6378.patch
        9 kB
        Varun Thacker

        Activity

        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Varun Thacker added a comment -

        Patch which throws the underlying exception.

        All tests pass and precommit is happy.

        Show
        Varun Thacker added a comment - Patch which throws the underlying exception. All tests pass and precommit is happy.
        Hide
        Adrien Grand added a comment -

        +1

        Show
        Adrien Grand added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1670453 from Varun Thacker in branch 'dev/trunk'
        [ https://svn.apache.org/r1670453 ]

        LUCENE-6378: Fix all RuntimeExceptions to throw the underlying root cause

        Show
        ASF subversion and git services added a comment - Commit 1670453 from Varun Thacker in branch 'dev/trunk' [ https://svn.apache.org/r1670453 ] LUCENE-6378 : Fix all RuntimeExceptions to throw the underlying root cause
        Hide
        ASF subversion and git services added a comment -

        Commit 1670564 from Varun Thacker in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1670564 ]

        LUCENE-6378: Fix all RuntimeExceptions to throw the underlying root cause (merged from trunk r1670453)

        Show
        ASF subversion and git services added a comment - Commit 1670564 from Varun Thacker in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1670564 ] LUCENE-6378 : Fix all RuntimeExceptions to throw the underlying root cause (merged from trunk r1670453)
        Hide
        Varun Thacker added a comment -

        Thanks Mike and Adrien!

        Show
        Varun Thacker added a comment - Thanks Mike and Adrien!
        Hide
        Anshum Gupta added a comment -

        Bulk close for 5.2.0.

        Show
        Anshum Gupta added a comment - Bulk close for 5.2.0.

          People

          • Assignee:
            Unassigned
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development