Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6369

Make queries more defensive and clone deeply

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Won't Fix
    • None
    • None
    • None
    • None
    • New

    Description

      It is very important for the query cache that queries be either immutable or clone deeply so that they cannot change after having been put into the cache.

      There are three issues that need to be addressed:

      • mutable queries such as boolean or phrase queries do not clone deeply
      • queries that wrap mutable objects such as TermQuery's term
      • filters inherit Query's default clone impl which is not enough in most cases

      Attachments

        1. LUCENE-6369.patch
          56 kB
          Adrien Grand
        2. immutable_queries.patch
          274 kB
          Adrien Grand

        Issue Links

          Activity

            People

              jpountz Adrien Grand
              jpountz Adrien Grand
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: