Lucene - Core
  1. Lucene - Core
  2. LUCENE-6311

IndexInput.toString should always confess when it's inside a compound file

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      MMapDir and RAMDir seem do this properly but at least SimpleFSDir and NIOFSDir do not state when a given name was opened from within a compound file.

      1. LUCENE-6311.patch
        6 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Patch with a test case in BaseCompoundFormatTestCase, and fixing the 2 "non-confessing" dir impls I found, and factoring out a protected method in IndexInput to create the String resourceDesc for sliced files.

        Show
        Michael McCandless added a comment - Patch with a test case in BaseCompoundFormatTestCase, and fixing the 2 "non-confessing" dir impls I found, and factoring out a protected method in IndexInput to create the String resourceDesc for sliced files.
        Hide
        Robert Muir added a comment -

        +1 ! I love that we now have a test for this.

        Show
        Robert Muir added a comment - +1 ! I love that we now have a test for this.
        Hide
        ASF subversion and git services added a comment -

        Commit 1662967 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1662967 ]

        LUCENE-6311: make sure IndexInput.toString confesses when it's within a compound file

        Show
        ASF subversion and git services added a comment - Commit 1662967 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1662967 ] LUCENE-6311 : make sure IndexInput.toString confesses when it's within a compound file
        Hide
        ASF subversion and git services added a comment -

        Commit 1662969 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1662969 ]

        LUCENE-6311: make sure IndexInput.toString confesses when it's within a compound file

        Show
        ASF subversion and git services added a comment - Commit 1662969 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1662969 ] LUCENE-6311 : make sure IndexInput.toString confesses when it's within a compound file
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development