Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      We already have maxDoc and numDocs, I think it's crazy we have a 3rd one docCount.

      We should just rename to maxDoc.

      1. LUCENE-6307.patch
        94 kB
        Michael McCandless
      2. LUCENE-6307.patch
        82 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Simple patch just touches a lot of files ...

        Show
        Michael McCandless added a comment - Simple patch just touches a lot of files ...
        Hide
        Adrien Grand added a comment -

        +1

        On IndexReader it is just maxDoc(), should it be maxDoc() too on SI? (instead of getMaxDoc())

        Show
        Adrien Grand added a comment - +1 On IndexReader it is just maxDoc(), should it be maxDoc() too on SI? (instead of getMaxDoc())
        Hide
        Robert Muir added a comment -

        I agree with Adrien. I think this will be more intuitive.

        Show
        Robert Muir added a comment - I agree with Adrien. I think this will be more intuitive.
        Hide
        Michael McCandless added a comment -

        OK I'll switch to just .maxDoc for consistency.

        Show
        Michael McCandless added a comment - OK I'll switch to just .maxDoc for consistency.
        Hide
        Michael McCandless added a comment -

        New patch, using maxDoc() consistently. I also changed a couple more places, e.g. MergeInfo.totalDocCount -> .totalMaxDoc, MergePolicy.OneMerge.totalDocCount -> .totalMaxDoc.

        Show
        Michael McCandless added a comment - New patch, using maxDoc() consistently. I also changed a couple more places, e.g. MergeInfo.totalDocCount -> .totalMaxDoc, MergePolicy.OneMerge.totalDocCount -> .totalMaxDoc.
        Hide
        ASF subversion and git services added a comment -

        Commit 1663371 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1663371 ]

        LUCENE-6307: rename confusing docCount -> maxDoc in several places

        Show
        ASF subversion and git services added a comment - Commit 1663371 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1663371 ] LUCENE-6307 : rename confusing docCount -> maxDoc in several places
        Hide
        ASF subversion and git services added a comment -

        Commit 1663376 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1663376 ]

        LUCENE-6307: rename confusing docCount -> maxDoc in several places

        Show
        ASF subversion and git services added a comment - Commit 1663376 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1663376 ] LUCENE-6307 : rename confusing docCount -> maxDoc in several places
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close for 5.3.0 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close for 5.3.0 release

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development