Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      We should replace TermsFilter with a TermsQuery like we started doing for other filters.

      1. LUCENE-6270.patch
        76 kB
        Adrien Grand

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch (which depends on LUCENE-6269). It takes the same approach as TermsFilter (sorted terms, pre-computed hash, implements Accountable) and just implements the query API instead of Filter. Like BooleanFilter we will need to keep the filter in 5.x given that it supports random-access.

        Show
        Adrien Grand added a comment - Here is a patch (which depends on LUCENE-6269 ). It takes the same approach as TermsFilter (sorted terms, pre-computed hash, implements Accountable) and just implements the query API instead of Filter. Like BooleanFilter we will need to keep the filter in 5.x given that it supports random-access.
        Hide
        Uwe Schindler added a comment -

        But TermsFilter may take a huuuge list of terms and it may use an automaton for that! Or do you mean TermFilter - but that was already removed in LUCENE-6222?

        Show
        Uwe Schindler added a comment - But TermsFilter may take a huuuge list of terms and it may use an automaton for that! Or do you mean TermFilter - but that was already removed in LUCENE-6222 ?
        Hide
        Uwe Schindler added a comment -

        Ah, TermsQuery - thanks!

        Show
        Uwe Schindler added a comment - Ah, TermsQuery - thanks!
        Hide
        Robert Muir added a comment -

        But TermsFilter may take a huuuge list of terms and it may use an automaton for that!

        I agree, we should look at this in a separate issue. We should at least use PrefixCodedTerms so its not so RAM wasteful.

        Show
        Robert Muir added a comment - But TermsFilter may take a huuuge list of terms and it may use an automaton for that! I agree, we should look at this in a separate issue. We should at least use PrefixCodedTerms so its not so RAM wasteful.
        Hide
        Adrien Grand added a comment -

        Turns out there is already an issue open for that: LUCENE-3893

        Show
        Adrien Grand added a comment - Turns out there is already an issue open for that: LUCENE-3893
        Hide
        ASF subversion and git services added a comment -

        Commit 1661395 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1661395 ]

        LUCENE-6270: Replace TermsFilter with TermsQuery.

        Show
        ASF subversion and git services added a comment - Commit 1661395 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1661395 ] LUCENE-6270 : Replace TermsFilter with TermsQuery.
        Hide
        ASF subversion and git services added a comment -

        Commit 1661396 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1661396 ]

        LUCENE-6270: Fix merge issues with LUCENE-6272.

        Show
        ASF subversion and git services added a comment - Commit 1661396 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1661396 ] LUCENE-6270 : Fix merge issues with LUCENE-6272 .
        Hide
        ASF subversion and git services added a comment -

        Commit 1661412 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1661412 ]

        LUCENE-6270: Replace TermsFilter with TermsQuery.

        Show
        ASF subversion and git services added a comment - Commit 1661412 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1661412 ] LUCENE-6270 : Replace TermsFilter with TermsQuery.
        Hide
        ASF subversion and git services added a comment -

        Commit 1661462 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1661462 ]

        LUCENE-6270: Fix test bug.

        Show
        ASF subversion and git services added a comment - Commit 1661462 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1661462 ] LUCENE-6270 : Fix test bug.
        Hide
        ASF subversion and git services added a comment -

        Commit 1661463 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1661463 ]

        LUCENE-6270: Fix test bug.

        Show
        ASF subversion and git services added a comment - Commit 1661463 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1661463 ] LUCENE-6270 : Fix test bug.
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development