Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Like TermFilter, we should remove this filter and recommend on using BooleanQuery instead. One reason why this is a bit more tricky than TermFilter is that BooleanFilter creates doc id sets that support random-access while a BooleanQuery would not provide random-access support.

      1. LUCENE-6269.patch
        52 kB
        Adrien Grand
      2. LUCENE-6269.patch
        40 kB
        Adrien Grand

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch. It required some changes to the facet module since it had expectations about random-access.

        Michael McCandless, Shai Erera, I would appreciate if you could have a look.

        Show
        Adrien Grand added a comment - Here is a patch. It required some changes to the facet module since it had expectations about random-access. Michael McCandless , Shai Erera , I would appreciate if you could have a look.
        Hide
        Uwe Schindler added a comment -

        Juhu! I hope we can nuke ChainedFilter, too. Unfortunately this one has some additional stuff like XOR.

        In fact, we could remove some of the methods in FixedBitSet & Co that are just there to AND/OR/XOR/... bitsets with other Iterators.

        Show
        Uwe Schindler added a comment - Juhu! I hope we can nuke ChainedFilter, too. Unfortunately this one has some additional stuff like XOR. In fact, we could remove some of the methods in FixedBitSet & Co that are just there to AND/OR/XOR/... bitsets with other Iterators.
        Hide
        Adrien Grand added a comment -

        Good point, I should probably try to get rid of ChainedFilter in the same issue. Will try and see how it goes.

        Show
        Adrien Grand added a comment - Good point, I should probably try to get rid of ChainedFilter in the same issue. Will try and see how it goes.
        Hide
        Adrien Grand added a comment -

        Oh, we already removed ChainedFilter. https://issues.apache.org/jira/browse/LUCENE-5984

        Show
        Adrien Grand added a comment - Oh, we already removed ChainedFilter. https://issues.apache.org/jira/browse/LUCENE-5984
        Hide
        Adrien Grand added a comment -

        New patch that also removes unused BitSet union/intersection logic.

        Show
        Adrien Grand added a comment - New patch that also removes unused BitSet union/intersection logic.
        Hide
        Michael McCandless added a comment -

        +1, thanks Adrien Grand!

        Show
        Michael McCandless added a comment - +1, thanks Adrien Grand !
        Hide
        ASF subversion and git services added a comment -

        Commit 1661366 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1661366 ]

        LUCENE-6269: Remove BooleanFilter.

        Show
        ASF subversion and git services added a comment - Commit 1661366 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1661366 ] LUCENE-6269 : Remove BooleanFilter.
        Hide
        ASF subversion and git services added a comment -

        Commit 1661370 from Adrien Grand in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1661370 ]

        LUCENE-6269: Remove BooleanFilter.

        Show
        ASF subversion and git services added a comment - Commit 1661370 from Adrien Grand in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1661370 ] LUCENE-6269 : Remove BooleanFilter.
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Adrien Grand
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development