Lucene - Core
  1. Lucene - Core
  2. LUCENE-6266

Remove unnecessary Directory parameters from SIS/SIPC/SI

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      A few methods take Directory where it makes no sense:

      Collection SegmentInfos.files(Directory dir, boolean includeSegmentsFile);
      String SegmentInfos.toString(Directory dir);
      String SegmentCommitInfo.toString(Directory dir, int pendingDelCount);
      String SegmentInfo.toString(Directory dir, int delCount);
      

      The incoming Directory parameter for files() is bogus, if assertions are enabled, it fails if any underlying segment's 'dir' differs. But if assertions are not enabled, it just silently drops them. If we want to add safety around this kind of thing, this is not the way.

      For toString(), it just makes the API hard to use for everyone. This change means commits have a working Object.toString() method.

        Activity

        Hide
        Robert Muir added a comment -

        Patch. all tests pass.

        Show
        Robert Muir added a comment - Patch. all tests pass.
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Simon Willnauer added a comment -

        +1 LGTM thanks rob

        Show
        Simon Willnauer added a comment - +1 LGTM thanks rob
        Hide
        ASF subversion and git services added a comment -

        Commit 1661172 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1661172 ]

        LUCENE-6266: Remove unnecessary Directory parameters from SIS/SIPC/SI

        Show
        ASF subversion and git services added a comment - Commit 1661172 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1661172 ] LUCENE-6266 : Remove unnecessary Directory parameters from SIS/SIPC/SI
        Hide
        ASF subversion and git services added a comment -

        Commit 1661177 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1661177 ]

        LUCENE-6266: remove deprecations

        Show
        ASF subversion and git services added a comment - Commit 1661177 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1661177 ] LUCENE-6266 : remove deprecations
        Hide
        ASF subversion and git services added a comment -

        Commit 1661189 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1661189 ]

        LUCENE-6266: Remove unnecessary Directory parameters from SIS/SIPC/SI

        Show
        ASF subversion and git services added a comment - Commit 1661189 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1661189 ] LUCENE-6266 : Remove unnecessary Directory parameters from SIS/SIPC/SI
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development