Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6266

Remove unnecessary Directory parameters from SIS/SIPC/SI

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.1, 6.0
    • None
    • None
    • New

    Description

      A few methods take Directory where it makes no sense:

      Collection SegmentInfos.files(Directory dir, boolean includeSegmentsFile);
      String SegmentInfos.toString(Directory dir);
      String SegmentCommitInfo.toString(Directory dir, int pendingDelCount);
      String SegmentInfo.toString(Directory dir, int delCount);
      

      The incoming Directory parameter for files() is bogus, if assertions are enabled, it fails if any underlying segment's 'dir' differs. But if assertions are not enabled, it just silently drops them. If we want to add safety around this kind of thing, this is not the way.

      For toString(), it just makes the API hard to use for everyone. This change means commits have a working Object.toString() method.

      Attachments

        1. LUCENE-6266.patch
          13 kB
          Robert Muir

        Activity

          People

            Unassigned Unassigned
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: