Lucene - Core
  1. Lucene - Core
  2. LUCENE-6248

Remove unused odd constants from StandardSyntaxParser.jj

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This block of constants struct me as odd – looked like a bug to me at first:

       public class StandardSyntaxParser implements SyntaxParser, StandardSyntaxParserConstants {
      
        private static final int CONJ_NONE =0;
        private static final int CONJ_AND =2;
        private static final int CONJ_OR =2; 
      

      but it turns out they're not used at all anymore – there is a Conjunction block that is all commented out.

        Issue Links

          Activity

          Hide
          Dawid Weiss added a comment -

          The patch is quite simple but it does affect the generated code-automaton. I just want to make sure leaving Conjunction wasn't intentional.

          Show
          Dawid Weiss added a comment - The patch is quite simple but it does affect the generated code-automaton. I just want to make sure leaving Conjunction wasn't intentional.
          Hide
          Uwe Schindler added a comment -

          If its unused, nuke it! I think it is a relict from earlier times. I remember about bugs with conjunctions...

          Show
          Uwe Schindler added a comment - If its unused, nuke it! I think it is a relict from earlier times. I remember about bugs with conjunctions...
          Hide
          ASF subversion and git services added a comment -

          Commit 1660315 from Dawid Weiss in branch 'dev/trunk'
          [ https://svn.apache.org/r1660315 ]

          LUCENE-6249: StandardQueryParser doesn't support pure negative clauses.
          LUCENE-6248: Remove unused odd constants from StandardSyntaxParser.jj

          Show
          ASF subversion and git services added a comment - Commit 1660315 from Dawid Weiss in branch 'dev/trunk' [ https://svn.apache.org/r1660315 ] LUCENE-6249 : StandardQueryParser doesn't support pure negative clauses. LUCENE-6248 : Remove unused odd constants from StandardSyntaxParser.jj
          Hide
          ASF subversion and git services added a comment -

          Commit 1660316 from Dawid Weiss in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1660316 ]

          LUCENE-6249: StandardQueryParser doesn't support pure negative clauses.
          LUCENE-6248: Remove unused odd constants from StandardSyntaxParser.jj

          Show
          ASF subversion and git services added a comment - Commit 1660316 from Dawid Weiss in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1660316 ] LUCENE-6249 : StandardQueryParser doesn't support pure negative clauses. LUCENE-6248 : Remove unused odd constants from StandardSyntaxParser.jj
          Hide
          Timothy Potter added a comment -

          Bulk close after 5.1 release

          Show
          Timothy Potter added a comment - Bulk close after 5.1 release
          Hide
          ASF subversion and git services added a comment -

          Commit 1711034 from Dawid Weiss in branch 'dev/branches/lucene_solr_4_10'
          [ https://svn.apache.org/r1711034 ]

          LUCENE-6249: StandardQueryParser doesn't support pure negative clauses.
          LUCENE-6248: Remove unused odd constants from StandardSyntaxParser.jj

          Show
          ASF subversion and git services added a comment - Commit 1711034 from Dawid Weiss in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1711034 ] LUCENE-6249 : StandardQueryParser doesn't support pure negative clauses. LUCENE-6248 : Remove unused odd constants from StandardSyntaxParser.jj

            People

            • Assignee:
              Dawid Weiss
              Reporter:
              Dawid Weiss
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development