Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6182

Spatial VisitorTemplate.visitScanned needn't be abstract

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1
    • Component/s: modules/spatial
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      visitScanned can be implemented, allowing subclasses to specialize if desired.

          protected void visitScanned(Cell cell) throws IOException {
            if (queryShape.relate(cell.getShape()).intersects()) {
              if (cell.isLeaf()) {
                visitLeaf(cell);
              } else {
                visit(cell);
              }
            }
          }
      

      Then I can remove Intersect's impl, and remove the one prefix-tree faceting.

      Additionally, I noticed collectDocs(FixBitSet) can be improved to take BitSet and call bitSet.or(docsEnum)

        Attachments

        1. LUCENE-6182.patch
          10 kB
          David Smiley

          Activity

            People

            • Assignee:
              dsmiley David Smiley
              Reporter:
              dsmiley David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: