[LUCENE-6182] Spatial VisitorTemplate.visitScanned needn't be abstract

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.1
• Component/s: modules/spatial
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 14/Jan/15 18:53
• Updated: 15/Apr/15 00:31
• Resolved: 15/Jan/15 16:10

Description

visitScanned can be implemented, allowing subclasses to specialize if desired.

    protected void visitScanned(Cell cell) throws IOException {
      if (queryShape.relate(cell.getShape()).intersects()) {
        if (cell.isLeaf()) {
          visitLeaf(cell);
        } else {
          visit(cell);
        }
      }
    }

Then I can remove Intersect's impl, and remove the one prefix-tree faceting.

Additionally, I noticed collectDocs(FixBitSet) can be improved to take BitSet and call bitSet.or(docsEnum)