Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      MemoryIndex could be enhanced to support payloads. It should be optional, defaulting to false.

        Issue Links

          Activity

          Hide
          David Smiley added a comment -

          This patch adds optional payload support to MemoryIndex. BytesRefArray was useful here.

          I added a configuration flag setting to Highlighter's QueryScorer and WeightedSpanTermExtractor so it gets propagated thru. There are tests at the highlighter level and MemoryIndex level.

          The only nocommit here is related to the maxReusedBytes option introduced by Simon Willnauer ... I didn't incorporate that. Perhaps BytesRefArray should have a constructor to provide one's own ByteBlockPool? Can we re-use the existing ByteBlockPool in MemoryIndex for this purpose?

          Show
          David Smiley added a comment - This patch adds optional payload support to MemoryIndex. BytesRefArray was useful here. I added a configuration flag setting to Highlighter's QueryScorer and WeightedSpanTermExtractor so it gets propagated thru. There are tests at the highlighter level and MemoryIndex level. The only nocommit here is related to the maxReusedBytes option introduced by Simon Willnauer ... I didn't incorporate that. Perhaps BytesRefArray should have a constructor to provide one's own ByteBlockPool? Can we re-use the existing ByteBlockPool in MemoryIndex for this purpose?
          Hide
          David Smiley added a comment -

          Subject to further feedback, I'll commit this as-is in ~ 12 hours. It's definitely not important to integrate the maxReusedBytes option with this payload storage option.

          Show
          David Smiley added a comment - Subject to further feedback, I'll commit this as-is in ~ 12 hours. It's definitely not important to integrate the maxReusedBytes option with this payload storage option.
          Hide
          ASF subversion and git services added a comment -

          Commit 1649798 from David Smiley in branch 'dev/trunk'
          [ https://svn.apache.org/r1649798 ]

          LUCENE-6155: Add payloads to MemoryIndex; add flag to HL QueryScorer

          Show
          ASF subversion and git services added a comment - Commit 1649798 from David Smiley in branch 'dev/trunk' [ https://svn.apache.org/r1649798 ] LUCENE-6155 : Add payloads to MemoryIndex; add flag to HL QueryScorer
          Hide
          ASF subversion and git services added a comment -

          Commit 1649799 from David Smiley in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1649799 ]

          LUCENE-6155: Add payloads to MemoryIndex; add flag to HL QueryScorer

          Show
          ASF subversion and git services added a comment - Commit 1649799 from David Smiley in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1649799 ] LUCENE-6155 : Add payloads to MemoryIndex; add flag to HL QueryScorer
          Hide
          Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          Anshum Gupta added a comment - Bulk close after 5.0 release.

            People

            • Assignee:
              David Smiley
              Reporter:
              David Smiley
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development