[LUCENE-6149] Infix suggesters' highlighting, allTermsRequired options are hardwired and not configurable for non-contextual lookup

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.9, 4.10.1, 4.10.2, 4.10.3
• Fix Version/s: 5.0, 6.0
• Component/s: modules/other
• Labels: suggester
• Assignee: Tomas Eduardo Fernandez Lobbe
• Reporter: Boon Low
• Created: 31/Dec/14 12:02
• Updated: 28/Aug/22 14:22
• Resolved: 07/Jan/15 19:54

Description

Highlighting and allTermsRequired are hardwired in AnalyzingInfixSuggester for non-contextual lookup (via Lookup) see true, true below:

AnalyzingInfixSuggester.java (extends Lookup.java)

public List<LookupResult> lookup(CharSequence key, Set<BytesRef> contexts, boolean onlyMorePopular, int num) throws IOException {
    return lookup(key, contexts, num, true, true);
}

/** Lookup, without any context. */
public List<LookupResult> lookup(CharSequence key, int num, boolean allTermsRequired, boolean doHighlight) throws IOException {
    return lookup(key, null, num, allTermsRequired, doHighlight);
  }

Lookup.java

public List<LookupResult> lookup(CharSequence key, boolean onlyMorePopular, int num) throws IOException {
    return lookup(key, null, onlyMorePopular, num);
}

The above means the majority of the current infix suggester lookup always return highlighted results with allTermsRequired in effect. There is no way to change this despite the options and improvement of LUCENE-6050, made to incorporate Boolean lookup clauses (MUST/SHOULD). This shortcoming has also been reported in SOLR-6648.

The suggesters (AnalyzingInfixSuggester, BlendedInfixSuggester) should provide a proper mechanism to set defaults for highlighting and "allTermsRequired", e.g. in constructors (and in Solr factories, thus configurable via solrconfig.xml).

Issue Links

• is required by: SOLR-6648 AnalyzingInfixLookupFactory always highlights suggestions