[LUCENE-6146] Directory.copy -> Directory.copyFrom

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Component/s: core/store
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 30/Dec/14 23:18
• Updated: 28/Aug/22 14:22
• Resolved: 01/Jan/15 15:29

Description

Spinoff of LUCENE-4746.

This method is currently:

copy(Directory to, String src, String dest, IOContext context)

But it would be better to restructure this so the destination directory is the one actually being changed by the operation:

copyFrom(Directory from, String src, String dest, IOContext context)

Besides fixing the order to make sense, adding it to the name might help prevent bugs like the current TrackingDirectoryWrapper impl (used by IndexWriter to track what files are used):

public void copy(Directory to, String src, String dest, IOContext context) throws IOException {
  createdFileNames.add(dest); // BUG!
  in.copy(to, src, dest, context);
}

Issue Links

• is related to: LUCENE-6150 Remove staleFiles set and onIndexOutputClosed from FSDirectory