[LUCENE-6121] Fix CachingTokenFilter to propagate reset() the first time

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Labels: random-chains
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 18/Dec/14 02:55
• Updated: 28/Aug/22 14:21
• Resolved: 06/Jan/22 02:39

Description

CachingTokenFilter should have been propagating reset() but only the first time and thus you would then use CachingTokenFilter in a more normal way – wrap it and call reset() then increment in a loop, etc., instead of knowing you need to reset() on what it wraps but not this token filter itself. That's weird. It's ab-normal for a TokenFilter to never propagate reset, so every user of CachingTokenFilter to date has worked around this by calling reset() on the underlying input instead of the final wrapping token filter (CachingTokenFilter in this case).

Issue Links

• relates to: LUCENE-6033 Add CachingTokenFilter.isCached and switch LinkedList to ArrayList