Lucene - Core
  1. Lucene - Core
  2. LUCENE-6097

Make IW.abortMerges and waitForMerges package private

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10.4, 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      These are crazy expert methods; must they be public?

      1. LUCENE-6097.patch
        8 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Simple patch.

        Show
        Michael McCandless added a comment - Simple patch.
        Hide
        Robert Muir added a comment -

        +1

        do tests survive a moderate beasting?
        I was only worried if they might rely on commit-on-close (vs waiting for merges).

        Show
        Robert Muir added a comment - +1 do tests survive a moderate beasting? I was only worried if they might rely on commit-on-close (vs waiting for merges).
        Hide
        Michael McCandless added a comment -

        I ran distributed beasting for 25 iterations ... only failure was LUCENE-5595 ... I'll commit shortly and let Jenkins chew on it.

        Show
        Michael McCandless added a comment - I ran distributed beasting for 25 iterations ... only failure was LUCENE-5595 ... I'll commit shortly and let Jenkins chew on it.
        Hide
        ASF subversion and git services added a comment -

        Commit 1643891 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1643891 ]

        LUCENE-6097: make abort/waitForMerges private

        Show
        ASF subversion and git services added a comment - Commit 1643891 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1643891 ] LUCENE-6097 : make abort/waitForMerges private
        Hide
        ASF subversion and git services added a comment -

        Commit 1643895 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1643895 ]

        LUCENE-6097: make abort/waitForMerges private

        Show
        ASF subversion and git services added a comment - Commit 1643895 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1643895 ] LUCENE-6097 : make abort/waitForMerges private
        Hide
        ASF subversion and git services added a comment -

        Commit 1643897 from Michael McCandless in branch 'dev/branches/lucene_solr_4_10'
        [ https://svn.apache.org/r1643897 ]

        LUCENE-6097: mark abort/waitForMerges deprecated

        Show
        ASF subversion and git services added a comment - Commit 1643897 from Michael McCandless in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1643897 ] LUCENE-6097 : mark abort/waitForMerges deprecated
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development