Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6085

Add back SI.attributes (safely)

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.0, 6.0
    • None
    • None
    • New

    Description

      We removed this for two reasons:

      • nothing was using it
      • the map is "unsafe" if a codec tried to write to it during in-place dv update.

      But Adrien has a real use case (LUCENE-5914), and I think we can just add some safety for the updates case (e.g. if the map is unmodifiable then the trap will not exist, any put() will throw exception). In general, we should have more safety in SI anyway (diagnostics map, too).

      Attachments

        1. LUCENE-6085.patch
          25 kB
          Robert Muir

        Activity

          People

            Unassigned Unassigned
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: