Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      We removed this for two reasons:

      • nothing was using it
      • the map is "unsafe" if a codec tried to write to it during in-place dv update.

      But Adrien has a real use case (LUCENE-5914), and I think we can just add some safety for the updates case (e.g. if the map is unmodifiable then the trap will not exist, any put() will throw exception). In general, we should have more safety in SI anyway (diagnostics map, too).

        Activity

        Hide
        Robert Muir added a comment -

        Here's a initial patch.

        Show
        Robert Muir added a comment - Here's a initial patch.
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        Adrien Grand added a comment -

        +1

        Show
        Adrien Grand added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1642919 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1642919 ]

        LUCENE-6085: add back SI.attributes

        Show
        ASF subversion and git services added a comment - Commit 1642919 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1642919 ] LUCENE-6085 : add back SI.attributes
        Hide
        ASF subversion and git services added a comment -

        Commit 1642943 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1642943 ]

        LUCENE-6085: add back SI.attributes

        Show
        ASF subversion and git services added a comment - Commit 1642943 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642943 ] LUCENE-6085 : add back SI.attributes
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development