Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Currently the codec API has SI writers, stored fields writers, and term vectors writers all deleting files, Stored fields and term vectors codec APIs have abort() methods, etc.

      This is outdated and scary, since TrackingDirectoryWrapper is used to the list of files the codec used, and this is ultimately passed to IndexFileDeleter.

        Activity

        Hide
        Robert Muir added a comment -

        Patch removing these abort methods and deletions from the codec API.

        This cleans it up a bit. We should still cleanup other deletions inside indexwriter itself on other issues though.

        Show
        Robert Muir added a comment - Patch removing these abort methods and deletions from the codec API. This cleans it up a bit. We should still cleanup other deletions inside indexwriter itself on other issues though.
        Hide
        Michael McCandless added a comment -

        +1

        This change is a little strange:

        +      // next event will cause IW to delete the old files: we use prepareCommit just as example
        +      iw.prepareCommit();
        

        Without this, was the test leaving deletable but not deleted files in the index (failing that counter check)? Why wasn't IW deleting the partially written files on hitting the IAE?

        Show
        Michael McCandless added a comment - +1 This change is a little strange: + // next event will cause IW to delete the old files: we use prepareCommit just as example + iw.prepareCommit(); Without this, was the test leaving deletable but not deleted files in the index (failing that counter check)? Why wasn't IW deleting the partially written files on hitting the IAE?
        Hide
        Robert Muir added a comment -

        Well, there is no processEvents() in the exception handling block of updateDocument, etc. I think this is a good thing.

        Show
        Robert Muir added a comment - Well, there is no processEvents() in the exception handling block of updateDocument, etc. I think this is a good thing.
        Hide
        ASF subversion and git services added a comment -

        Commit 1642558 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1642558 ]

        LUCENE-6082: remove abort() from codec apis

        Show
        ASF subversion and git services added a comment - Commit 1642558 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1642558 ] LUCENE-6082 : remove abort() from codec apis
        Hide
        ASF subversion and git services added a comment -

        Commit 1642560 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1642560 ]

        LUCENE-6082: simplify exception handling in simpletext .si format

        Show
        ASF subversion and git services added a comment - Commit 1642560 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1642560 ] LUCENE-6082 : simplify exception handling in simpletext .si format
        Hide
        ASF subversion and git services added a comment -

        Commit 1642562 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1642562 ]

        LUCENE-6082: remove abort() from codec apis

        Show
        ASF subversion and git services added a comment - Commit 1642562 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642562 ] LUCENE-6082 : remove abort() from codec apis
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development