Lucene - Core
  1. Lucene - Core
  2. LUCENE-6044

Add backcompat for TokenFilters with posInc=false before 4.4

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      In Lucene 4.4, a number of token filters supporting the enablePositionIncrements=false setting were changed to default to true. However, with Lucene 5.0, the setting was removed altogether. We should have backcompat for this setting, as well as work when used with a TokenFilterFactory and match version < 4.4.

        Activity

        Hide
        Ryan Ernst added a comment - - edited

        Patch. I also added backcompat for TrimFilter, which had updateOffsets support change in 4.4.

        Show
        Ryan Ernst added a comment - - edited Patch. I also added backcompat for TrimFilter, which had updateOffsets support change in 4.4.
        Hide
        Robert Muir added a comment -

        +1

        Show
        Robert Muir added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1636368 from Ryan Ernst in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1636368 ]

        LUCENE-6044: Fixed backcompat support for token filters with enablePositionIncrements=false

        Show
        ASF subversion and git services added a comment - Commit 1636368 from Ryan Ernst in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1636368 ] LUCENE-6044 : Fixed backcompat support for token filters with enablePositionIncrements=false
        Hide
        ASF subversion and git services added a comment -

        Commit 1657992 from Steve Rowe in branch 'dev/trunk'
        [ https://svn.apache.org/r1657992 ]

        LUCENE-6044: add CHANGES entry on trunk; remove mention of enablePositionIncrements from test schemas

        Show
        ASF subversion and git services added a comment - Commit 1657992 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1657992 ] LUCENE-6044 : add CHANGES entry on trunk; remove mention of enablePositionIncrements from test schemas
        Hide
        ASF subversion and git services added a comment -

        Commit 1657994 from Steve Rowe in branch 'dev/trunk'
        [ https://svn.apache.org/r1657994 ]

        LUCENE-6044: removed one last enablePositionIncrements mention from a test schema

        Show
        ASF subversion and git services added a comment - Commit 1657994 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1657994 ] LUCENE-6044 : removed one last enablePositionIncrements mention from a test schema
        Hide
        ASF subversion and git services added a comment -

        Commit 1657995 from Steve Rowe in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1657995 ]

        LUCENE-6044: remove mention of enablePositionIncrements from test schemas (merged trunk r1657992 and r1657994)

        Show
        ASF subversion and git services added a comment - Commit 1657995 from Steve Rowe in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1657995 ] LUCENE-6044 : remove mention of enablePositionIncrements from test schemas (merged trunk r1657992 and r1657994)
        Hide
        ASF subversion and git services added a comment -

        Commit 1657996 from Steve Rowe in branch 'dev/branches/lucene_solr_5_0'
        [ https://svn.apache.org/r1657996 ]

        LUCENE-6044: remove mention of enablePositionIncrements from test schemas (merged branch_5x 1657995)

        Show
        ASF subversion and git services added a comment - Commit 1657996 from Steve Rowe in branch 'dev/branches/lucene_solr_5_0' [ https://svn.apache.org/r1657996 ] LUCENE-6044 : remove mention of enablePositionIncrements from test schemas (merged branch_5x 1657995)
        Hide
        ASF subversion and git services added a comment -

        Commit 1658000 from Steve Rowe in branch 'dev/trunk'
        [ https://svn.apache.org/r1658000 ]

        LUCENE-6044: removed one last (for realz this time) enablePositionIncrements mention from a test schema

        Show
        ASF subversion and git services added a comment - Commit 1658000 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1658000 ] LUCENE-6044 : removed one last (for realz this time) enablePositionIncrements mention from a test schema
        Hide
        Steve Rowe added a comment -

        JapanesePartOfSpeechStopFilter extends FilteringTokenFilter, and existed prior to Lucene 4.4, but was not included among the classes that were addressed by this issue.

        Show
        Steve Rowe added a comment - JapanesePartOfSpeechStopFilter extends FilteringTokenFilter , and existed prior to Lucene 4.4, but was not included among the classes that were addressed by this issue.
        Hide
        Steve Rowe added a comment - - edited

        Patch adding back-compat support for enablePositionIncrements=false in JapanesePartOfSpeechStopFilter.

        Committing shortly.

        Show
        Steve Rowe added a comment - - edited Patch adding back-compat support for enablePositionIncrements = false in JapanesePartOfSpeechStopFilter . Committing shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1658030 from Steve Rowe in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1658030 ]

        LUCENE-6044: Fixed backcompat support for JapanesePartOfSpeechStopFilter with enablePositionIncrements=false

        Show
        ASF subversion and git services added a comment - Commit 1658030 from Steve Rowe in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1658030 ] LUCENE-6044 : Fixed backcompat support for JapanesePartOfSpeechStopFilter with enablePositionIncrements=false
        Hide
        Steve Rowe added a comment -

        Committed the JapanesePartOfSpeechStopFilter backcompat fix to branch_5x and lucene_solr_5_0.

        Show
        Steve Rowe added a comment - Committed the JapanesePartOfSpeechStopFilter backcompat fix to branch_5x and lucene_solr_5_0.
        Hide
        ASF subversion and git services added a comment -

        Commit 1658031 from Steve Rowe in branch 'dev/branches/lucene_solr_5_0'
        [ https://svn.apache.org/r1658031 ]

        LUCENE-6044: Fixed backcompat support for JapanesePartOfSpeechStopFilter with enablePositionIncrements=false (merged branch_5x r1658030)

        Show
        ASF subversion and git services added a comment - Commit 1658031 from Steve Rowe in branch 'dev/branches/lucene_solr_5_0' [ https://svn.apache.org/r1658031 ] LUCENE-6044 : Fixed backcompat support for JapanesePartOfSpeechStopFilter with enablePositionIncrements=false (merged branch_5x r1658030)
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Ryan Ernst
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development