Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6011

CompressingTermVectors should put checkDoc and checkPosition within assert

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • core/codecs
    • None
    • New

    Description

      CompressingTermVectorsReader.TVDocsEnum calls checkPosition() and checkDoc() but not from within asserts. And nextPosition() has some leading checks, also not within asserts. I believe these should all be within asserts. This is low-level code that can get called a ton of times, particularly via TokenSources.getTokenStream.

      I'd be happy to create a patch there is preliminary agreement.

      Attachments

        Activity

          People

            Unassigned Unassigned
            dsmiley David Smiley
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: