Lucene - Core
  1. Lucene - Core
  2. LUCENE-5971

Separate backcompat creation script from adding version

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The recently created bumpVersion.py attempts to create a new backcompat index if the default codec has changed. However, we now want to create a backcompat index for every released version, instead of just when there is a change to the default codec.

      We should have a separate script which creates the backcompat indexes. It can even work directly on the released artifacts (by pulling down from mirrors once released), so that there is no possibility for generating the index from an incorrect svn/git checkout.

        Activity

        Hide
        Ryan Ernst added a comment -

        This patch does the following:

        • Removes CreateBackwardsCompatibilityIndex class, which was just to avoid tests from running the index creation methods. Instead, it uses assumeTrue methods, and requires passing -Dtests.bwcdir when creating backcompat indexes.
        • Renames all backcompat index files to contain the exact toString of their version, instead of a squash/minified variant. This allows using Version parsing and comparison for checking all versions have a test (and for future tests, if needed as was in the past when older codecs did not support certain features).
        • Adds addBackcompatIndexes.py script, which was extracted from bumpVersion.py
        • Tweaks TestBackwardsCompatibility.testAllVersionsTested to allow a single "missing" test, which could be when we are in the middle of releasing a new version (so tests don't break as soon as a new constant is added to Version)
        Show
        Ryan Ernst added a comment - This patch does the following: Removes CreateBackwardsCompatibilityIndex class, which was just to avoid tests from running the index creation methods. Instead, it uses assumeTrue methods, and requires passing -Dtests.bwcdir when creating backcompat indexes. Renames all backcompat index files to contain the exact toString of their version, instead of a squash/minified variant. This allows using Version parsing and comparison for checking all versions have a test (and for future tests, if needed as was in the past when older codecs did not support certain features). Adds addBackcompatIndexes.py script, which was extracted from bumpVersion.py Tweaks TestBackwardsCompatibility.testAllVersionsTested to allow a single "missing" test, which could be when we are in the middle of releasing a new version (so tests don't break as soon as a new constant is added to Version )
        Hide
        ASF subversion and git services added a comment -

        Commit 1627419 from Ryan Ernst in branch 'dev/trunk'
        [ https://svn.apache.org/r1627419 ]

        LUCENE-5971: Create addBackcompatIndexes.py script to build and add backcompat test indexes

        Show
        ASF subversion and git services added a comment - Commit 1627419 from Ryan Ernst in branch 'dev/trunk' [ https://svn.apache.org/r1627419 ] LUCENE-5971 : Create addBackcompatIndexes.py script to build and add backcompat test indexes
        Hide
        ASF subversion and git services added a comment -

        Commit 1627438 from Ryan Ernst in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1627438 ]

        LUCENE-5971: Create addBackcompatIndexes.py script to build and add backcompat test indexes (merged 1627419)

        Show
        ASF subversion and git services added a comment - Commit 1627438 from Ryan Ernst in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1627438 ] LUCENE-5971 : Create addBackcompatIndexes.py script to build and add backcompat test indexes (merged 1627419)
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Ryan Ernst
            Reporter:
            Ryan Ernst
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development