Lucene - Core
  1. Lucene - Core
  2. LUCENE-5968

Improve error message when 'ant beast' is run on top-level modules

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      As discussed at http://markmail.org/thread/c5y63pmvpgyrmct5

      'ant beast' currently gives confusing error messages when run on top-level modules, this makes it clear that it should only be run within a module.

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user andyetitmoves opened a pull request:

        https://github.com/apache/lucene-solr/pull/96

        Explicitly stop beast from running on top-level modules

        Patch for LUCENE-5968

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-beast-error

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/96.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #96


        commit 79578f7cd4825d3d0d6700c4ec5581374216ac6f
        Author: Ramkumar Aiyengar <andyetitmoves@gmail.com>
        Date: 2014-09-21T07:33:59Z

        Explicitly stop beast from running on top-level modules


        Show
        ASF GitHub Bot added a comment - GitHub user andyetitmoves opened a pull request: https://github.com/apache/lucene-solr/pull/96 Explicitly stop beast from running on top-level modules Patch for LUCENE-5968 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-beast-error Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 commit 79578f7cd4825d3d0d6700c4ec5581374216ac6f Author: Ramkumar Aiyengar <andyetitmoves@gmail.com> Date: 2014-09-21T07:33:59Z Explicitly stop beast from running on top-level modules
        Hide
        Ramkumar Aiyengar added a comment -

        Uwe Schindler, Hoss Man: The pull request above has changes suggested by both, could you check and commit?

        Show
        Ramkumar Aiyengar added a comment - Uwe Schindler , Hoss Man : The pull request above has changes suggested by both, could you check and commit?
        Hide
        Uwe Schindler added a comment -

        Hi,
        would it be possible to remove the description from the top-level modules? As the ant beast target does not work, it should not appear in "ant -projecthelp".

        Show
        Uwe Schindler added a comment - Hi, would it be possible to remove the description from the top-level modules? As the ant beast target does not work, it should not appear in "ant -projecthelp".
        Hide
        ASF GitHub Bot added a comment -

        Github user uschindler commented on the pull request:

        https://github.com/apache/lucene-solr/pull/96#issuecomment-56595072

        Hi, see comments on https://issues.apache.org/jira/browse/LUCENE-5968 !

        Show
        ASF GitHub Bot added a comment - Github user uschindler commented on the pull request: https://github.com/apache/lucene-solr/pull/96#issuecomment-56595072 Hi, see comments on https://issues.apache.org/jira/browse/LUCENE-5968 !
        Hide
        Ramkumar Aiyengar added a comment -

        Done..

        Show
        Ramkumar Aiyengar added a comment - Done..
        Hide
        Ramkumar Aiyengar added a comment -

        Hey Uwe Schindler, I have addressed your comments, could this be merged in? Thanks!

        Show
        Ramkumar Aiyengar added a comment - Hey Uwe Schindler , I have addressed your comments, could this be merged in? Thanks!
        Hide
        Uwe Schindler added a comment -

        Sorry,
        I missed this issue. I will commit in a moment. Sorry.

        Uwe

        Show
        Uwe Schindler added a comment - Sorry, I missed this issue. I will commit in a moment. Sorry. Uwe
        Hide
        ASF subversion and git services added a comment -

        Commit 1642488 from Uwe Schindler in branch 'dev/trunk'
        [ https://svn.apache.org/r1642488 ]

        LUCENE-5968: Improve error message when 'ant beast' is run on top-level modules
        This closes #96

        Show
        ASF subversion and git services added a comment - Commit 1642488 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1642488 ] LUCENE-5968 : Improve error message when 'ant beast' is run on top-level modules This closes #96
        Hide
        ASF subversion and git services added a comment -

        Commit 1642489 from Uwe Schindler in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1642489 ]

        Merged revision(s) 1642488 from lucene/dev/trunk:
        LUCENE-5968: Improve error message when 'ant beast' is run on top-level modules
        This closes #96

        Show
        ASF subversion and git services added a comment - Commit 1642489 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642489 ] Merged revision(s) 1642488 from lucene/dev/trunk: LUCENE-5968 : Improve error message when 'ant beast' is run on top-level modules This closes #96
        Hide
        ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/lucene-solr/pull/96

        Show
        ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/96
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Ramkumar Aiyengar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development