Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.10
    • Fix Version/s: 5.0, 6.0
    • Component/s: core/other
    • Labels:
    • Lucene Fields:
      New, Patch Available

      Description

      Reworked AnalyzingSuggester.replaceSep() to use Automaton.Builder instead of Automaton. This avoids most of the unnecessary allocation of memory via grow*().

      1. replaceSep.diff
        3 kB
        Markus Heiden

        Activity

        Hide
        Markus Heiden added a comment -

        Patch with suggested changes.

        Show
        Markus Heiden added a comment - Patch with suggested changes.
        Hide
        Michael McCandless added a comment -

        Thanks Markus, looks great, I'll commit shortly.

        Show
        Michael McCandless added a comment - Thanks Markus, looks great, I'll commit shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1626241 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1626241 ]

        LUCENE-5963: more efficient AnalyzingSuggester.replaceSep

        Show
        ASF subversion and git services added a comment - Commit 1626241 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1626241 ] LUCENE-5963 : more efficient AnalyzingSuggester.replaceSep
        Hide
        ASF subversion and git services added a comment -

        Commit 1626242 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1626242 ]

        LUCENE-5963: more efficient AnalyzingSuggester.replaceSep

        Show
        ASF subversion and git services added a comment - Commit 1626242 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1626242 ] LUCENE-5963 : more efficient AnalyzingSuggester.replaceSep
        Hide
        Michael McCandless added a comment -

        Thanks Markus!

        Show
        Michael McCandless added a comment - Thanks Markus!
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Markus Heiden
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development