Lucene - Core
  1. Lucene - Core
  2. LUCENE-5960

Avoid grow of Set in AnalyzingSuggester.topoSortStates(Automaton)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.10
    • Fix Version/s: 5.0, 6.0
    • Component/s: core/other
    • Labels:
    • Lucene Fields:
      New, Patch Available

      Description

      Converted "visited" to a BitSet and sized it correctly in AnalyzingSuggester.topoSortStates(Automaton). This avoids dynamic resizing of the set.

        Activity

        Hide
        Markus Heiden added a comment -

        Patch with suggested changes.

        Show
        Markus Heiden added a comment - Patch with suggested changes.
        Hide
        Michael McCandless added a comment -

        Thanks Markus, this looks great ... I'll commit shortly.

        Show
        Michael McCandless added a comment - Thanks Markus, this looks great ... I'll commit shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1625965 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1625965 ]

        LUCENE-5960: Use a more efficient bitset, not a Set<Integer>, to track visited states

        Show
        ASF subversion and git services added a comment - Commit 1625965 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1625965 ] LUCENE-5960 : Use a more efficient bitset, not a Set<Integer>, to track visited states
        Hide
        ASF subversion and git services added a comment -

        Commit 1625966 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1625966 ]

        LUCENE-5960: Use a more efficient bitset, not a Set<Integer>, to track visited states

        Show
        ASF subversion and git services added a comment - Commit 1625966 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1625966 ] LUCENE-5960 : Use a more efficient bitset, not a Set<Integer>, to track visited states
        Hide
        Michael McCandless added a comment -

        Thanks Markus!

        Show
        Michael McCandless added a comment - Thanks Markus!
        Hide
        ASF subversion and git services added a comment -

        Commit 1625998 from Michael McCandless in branch 'dev/trunk'
        [ https://svn.apache.org/r1625998 ]

        LUCENE-5960: move CHANGES entry under 5.0

        Show
        ASF subversion and git services added a comment - Commit 1625998 from Michael McCandless in branch 'dev/trunk' [ https://svn.apache.org/r1625998 ] LUCENE-5960 : move CHANGES entry under 5.0
        Hide
        ASF subversion and git services added a comment -

        Commit 1625999 from Michael McCandless in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1625999 ]

        LUCENE-5960: move CHANGES entry under 5.0

        Show
        ASF subversion and git services added a comment - Commit 1625999 from Michael McCandless in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1625999 ] LUCENE-5960 : move CHANGES entry under 5.0
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Markus Heiden
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development