[LUCENE-5945] Full cutover to Path api from java.io.File

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 12/Sep/14 16:46
• Updated: 28/Aug/22 14:15
• Resolved: 13/Sep/14 21:47

Description

Using NIO2 has a lot of benefits:

• more fine grained exception handling
• clearer semantics about what happens
• additional functionality
• possibility to work with virtual filesystems, etc.

We already banned File.delete and switched to Files.delete, I think we should ban File completely (except for some sugar methods that just forward with .toPath, like FSDirectory.open)

For tests, ideally we go a little further and ban methods like FileSystems.getDefault(). Instead we could exempt LuceneTestCase and ensure all Paths are created via one protected method. This leaves open the possibility to mock up filesystem behavior at a lower level in tests in the future.

Issue Links

• breaks: LUCENE-7188 IllegalStateException in NRTCachingDirectory.listAll
• is related to: LUCENE-8617 FSDirectory tries to create MMapDirectory on non default file system
• is related to: LUCENE-6542 FSDirectory throws AccessControlException unless you grant write access to the index