Lucene - Core
  1. Lucene - Core
  2. LUCENE-5933

Add FilterSpans to allow easily wrapping a Spans impl

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      I found this useful while working with spans recently. It's simple and straightforward. I'll add a patch shortly.

        Activity

        Hide
        Shai Erera added a comment -

        Trivial patch. I couldn't decide between FilterSpans and SpansWrapper - any preferences?

        Show
        Shai Erera added a comment - Trivial patch. I couldn't decide between FilterSpans and SpansWrapper - any preferences?
        Hide
        David Smiley added a comment -

        Not plural; existing span queries are "...Span...". I guess I like SpanQueryWrapper. "Wrapper" appears often in our classes.

        Show
        David Smiley added a comment - Not plural; existing span queries are "...Span...". I guess I like SpanQueryWrapper. "Wrapper" appears often in our classes.
        Hide
        Shai Erera added a comment -

        Spans is not plural, it's the name of the class Spans . This one wraps/filters a Spans impl, not SpanQuery. Therefore the decision would be between FilterSpans and SpansWrapper. I have no strong feelings about either. I used Filter since we have that in FilterDirectory and FilterAtomicReader

        Show
        Shai Erera added a comment - Spans is not plural, it's the name of the class Spans . This one wraps/filters a Spans impl, not SpanQuery. Therefore the decision would be between FilterSpans and SpansWrapper. I have no strong feelings about either. I used Filter since we have that in FilterDirectory and FilterAtomicReader
        Hide
        David Smiley added a comment -

        Ah, I see Either name is fine.

        Show
        David Smiley added a comment - Ah, I see Either name is fine.
        Hide
        ASF subversion and git services added a comment -

        Commit 1624327 from Shai Erera in branch 'dev/trunk'
        [ https://svn.apache.org/r1624327 ]

        LUCENE-5933: add FilterSpans

        Show
        ASF subversion and git services added a comment - Commit 1624327 from Shai Erera in branch 'dev/trunk' [ https://svn.apache.org/r1624327 ] LUCENE-5933 : add FilterSpans
        Hide
        ASF subversion and git services added a comment -

        Commit 1624329 from Shai Erera in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1624329 ]

        LUCENE-5933: add FilterSpans

        Show
        ASF subversion and git services added a comment - Commit 1624329 from Shai Erera in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1624329 ] LUCENE-5933 : add FilterSpans
        Hide
        Shai Erera added a comment -

        Committed to trunk and 4x

        Show
        Shai Erera added a comment - Committed to trunk and 4x
        Hide
        ASF subversion and git services added a comment -

        Commit 1624358 from Shai Erera in branch 'dev/trunk'
        [ https://svn.apache.org/r1624358 ]

        LUCENE-5933: fix eol-style

        Show
        ASF subversion and git services added a comment - Commit 1624358 from Shai Erera in branch 'dev/trunk' [ https://svn.apache.org/r1624358 ] LUCENE-5933 : fix eol-style
        Hide
        ASF subversion and git services added a comment -

        Commit 1624359 from Shai Erera in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1624359 ]

        LUCENE-5933: fix eol-style

        Show
        ASF subversion and git services added a comment - Commit 1624359 from Shai Erera in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1624359 ] LUCENE-5933 : fix eol-style
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development