Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This option is dangerous. It sounds so good though that people are quick to use it, but it definitely drops entire segments.

      The commandline flag should be someting other than -fix (e.g. -exorcise).

      I dont agree with the current description of the option either. True, it does have *WARNING* but I think it should read more like the scary options in 'man hdparm'.

      Like hdparm, we could fail if you provide it with an even more ridiculous warning, and make you run again with --yes-i-really-know-what-i-am-doing as well.

        Activity

        Hide
        Michael McCandless added a comment -

        +1, this badly needs to be renamed.

        And +1 for -exorcise.

        Show
        Michael McCandless added a comment - +1, this badly needs to be renamed. And +1 for -exorcise.
        Hide
        Robert Muir added a comment -

        patch renaming the option. I also sprinkled LOSES DATA in various places.

        Show
        Robert Muir added a comment - patch renaming the option. I also sprinkled LOSES DATA in various places.
        Hide
        Michael McCandless added a comment -

        +1

        Show
        Michael McCandless added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1628579 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1628579 ]

        LUCENE-5924: rename CheckIndex -fix option and add more warnings about what it actually does

        Show
        ASF subversion and git services added a comment - Commit 1628579 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1628579 ] LUCENE-5924 : rename CheckIndex -fix option and add more warnings about what it actually does
        Hide
        ASF subversion and git services added a comment -

        Commit 1628582 from Robert Muir in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1628582 ]

        LUCENE-5924: rename CheckIndex -fix option and add more warnings about what it actually does

        Show
        ASF subversion and git services added a comment - Commit 1628582 from Robert Muir in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1628582 ] LUCENE-5924 : rename CheckIndex -fix option and add more warnings about what it actually does
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development