Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.10
    • Fix Version/s: 4.9.1, 4.10.1, 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This DocIdSet claims it is cacheable although bad things could happen if it was cached since it is not thread-safe and keeps handles to open files.

      The fix is simple, especially given that this doc id set is cheap to create. But I'm wondering if there is a way we could protect ourselves from such bugs in the future.

        Activity

        Hide
        Adrien Grand added a comment -

        Here is a patch.

        Show
        Adrien Grand added a comment - Here is a patch.
        Hide
        Ryan Ernst added a comment -

        LGTM.

        Show
        Ryan Ernst added a comment - LGTM.
        Hide
        ASF subversion and git services added a comment -

        Commit 1623345 from Adrien Grand in branch 'dev/trunk'
        [ https://svn.apache.org/r1623345 ]

        LUCENE-5922: DocValuesDocIdSet is not cacheable.

        Show
        ASF subversion and git services added a comment - Commit 1623345 from Adrien Grand in branch 'dev/trunk' [ https://svn.apache.org/r1623345 ] LUCENE-5922 : DocValuesDocIdSet is not cacheable.
        Hide
        ASF subversion and git services added a comment -

        Commit 1623349 from Adrien Grand in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1623349 ]

        LUCENE-5922: FieldCacheDocIdSet is not cacheable.

        Show
        ASF subversion and git services added a comment - Commit 1623349 from Adrien Grand in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1623349 ] LUCENE-5922 : FieldCacheDocIdSet is not cacheable.
        Hide
        Adrien Grand added a comment -

        Thanks Ryan!

        Show
        Adrien Grand added a comment - Thanks Ryan!
        Hide
        Michael McCandless added a comment -

        I'll backport to 4.9.1...

        Show
        Michael McCandless added a comment - I'll backport to 4.9.1...
        Hide
        ASF subversion and git services added a comment -

        Commit 1625413 from Michael McCandless in branch 'dev/branches/lucene_solr_4_9'
        [ https://svn.apache.org/r1625413 ]

        LUCENE-5922: backport to 4.9.x

        Show
        ASF subversion and git services added a comment - Commit 1625413 from Michael McCandless in branch 'dev/branches/lucene_solr_4_9' [ https://svn.apache.org/r1625413 ] LUCENE-5922 : backport to 4.9.x
        Hide
        Michael McCandless added a comment -

        Reopen for 4.10.1

        Show
        Michael McCandless added a comment - Reopen for 4.10.1
        Hide
        ASF subversion and git services added a comment -

        Commit 1626212 from Michael McCandless in branch 'dev/branches/lucene_solr_4_10'
        [ https://svn.apache.org/r1626212 ]

        LUCENE-5922: backport to 4.10.1

        Show
        ASF subversion and git services added a comment - Commit 1626212 from Michael McCandless in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1626212 ] LUCENE-5922 : backport to 4.10.1
        Hide
        Michael McCandless added a comment -

        Bulk close for Lucene/Solr 4.10.1 release

        Show
        Michael McCandless added a comment - Bulk close for Lucene/Solr 4.10.1 release

          People

          • Assignee:
            Unassigned
            Reporter:
            Adrien Grand
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development