Lucene - Core
  1. Lucene - Core
  2. LUCENE-5916

Static scope test components should be consistent between tests (and test iterations)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      An example of a thing breaking this rule is FaultyIndexInput – its internal 'count' field is incremented at the class level; if a test is reiterated, any counter-based events will happen across the same test's reiterations (instead of being consistent and local to a test).

      1. LUCENE-5916.patch
        5 kB
        Erick Erickson
      2. LUCENE-5916.patch
        5 kB
        Dawid Weiss

        Activity

        Hide
        Dawid Weiss added a comment -

        Patch fixing FaultyIndexInput.

        Show
        Dawid Weiss added a comment - Patch fixing FaultyIndexInput.
        Hide
        ASF subversion and git services added a comment -

        Commit 1621889 from Erick Erickson in branch 'dev/trunk'
        [ https://svn.apache.org/r1621889 ]

        LUCENE-5916: Static scope test components should be consistent between tests (and test iterations)

        Show
        ASF subversion and git services added a comment - Commit 1621889 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1621889 ] LUCENE-5916 : Static scope test components should be consistent between tests (and test iterations)
        Hide
        Erick Erickson added a comment -

        Added note to CHANGES.txt crediting Dawid.

        Show
        Erick Erickson added a comment - Added note to CHANGES.txt crediting Dawid.
        Hide
        ASF subversion and git services added a comment -

        Commit 1621892 from Erick Erickson in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1621892 ]

        LUCENE-5916: Static scope test components should be consistent between tests (and test iterations)

        Show
        ASF subversion and git services added a comment - Commit 1621892 from Erick Erickson in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1621892 ] LUCENE-5916 : Static scope test components should be consistent between tests (and test iterations)
        Hide
        Erick Erickson added a comment -

        Thanks Dawid!

        Show
        Erick Erickson added a comment - Thanks Dawid!
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Dawid Weiss
            Reporter:
            Dawid Weiss
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development