Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      There are still a couple things taking Version in their constructor (AnalyzingInfixSuggester/BlendedInfixSuggester), TEST_VERSION_CURRENT isn't needed anymore, and there are a number of places with :Post-Release-Update-Version:, which should be possible to remove completely.

      1. LUCENE-5900.patch
        67 kB
        Ryan Ernst
      2. LUCENE-5900-factories.patch
        7 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Ryan Ernst added a comment -

          Patch with:

          • Adding constructors for AnalyzingInfixSuggester and BlendedInfixSuggester which use the Version from the passed in analyzer. Deprecated the old constructors.
          • Added constructor to ICUCollationKeyAnalyzer which does not take a Version and deprecated the old constructor.
          • Removed TEST_VERSION_CURRENT. Replaces with Version.LATEST where necessary, or just used an alternate function/ctor that didn't take Version.
          • Removed FacetExamples.java. It's only member, EXAMPLES_VER, was not used.
          • Removed all :Post-Release-Update-Version: notes. Many were already dead comments, and the rest could be replaced either with Version.CURRENT, or have version removed from the example.
          Show
          Ryan Ernst added a comment - Patch with: Adding constructors for AnalyzingInfixSuggester and BlendedInfixSuggester which use the Version from the passed in analyzer. Deprecated the old constructors. Added constructor to ICUCollationKeyAnalyzer which does not take a Version and deprecated the old constructor. Removed TEST_VERSION_CURRENT . Replaces with Version.LATEST where necessary, or just used an alternate function/ctor that didn't take Version . Removed FacetExamples.java . It's only member, EXAMPLES_VER , was not used. Removed all :Post-Release-Update-Version: notes. Many were already dead comments, and the rest could be replaced either with Version.CURRENT, or have version removed from the example.
          Hide
          Areek Zillur added a comment -

          +1 on the new *InfixSuggester ctors

          Show
          Areek Zillur added a comment - +1 on the new *InfixSuggester ctors
          Hide
          ASF subversion and git services added a comment -

          Commit 1620509 from Ryan Ernst in branch 'dev/trunk'
          [ https://svn.apache.org/r1620509 ]

          LUCENE-5900: More Version cleanup

          Show
          ASF subversion and git services added a comment - Commit 1620509 from Ryan Ernst in branch 'dev/trunk' [ https://svn.apache.org/r1620509 ] LUCENE-5900 : More Version cleanup
          Hide
          ASF subversion and git services added a comment -

          Commit 1620510 from Ryan Ernst in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1620510 ]

          LUCENE-5900: More Version cleanup (merged 1620509)

          Show
          ASF subversion and git services added a comment - Commit 1620510 from Ryan Ernst in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1620510 ] LUCENE-5900 : More Version cleanup (merged 1620509)
          Hide
          Ryan Ernst added a comment -

          Reverted 1620509, still working on merge.

          Show
          Ryan Ernst added a comment - Reverted 1620509, still working on merge.
          Hide
          ASF subversion and git services added a comment -

          Commit 1620524 from Ryan Ernst in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1620524 ]

          LUCENE-5900: More Version cleanup (merged 1620509)

          Show
          ASF subversion and git services added a comment - Commit 1620524 from Ryan Ernst in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1620524 ] LUCENE-5900 : More Version cleanup (merged 1620509)
          Hide
          Uwe Schindler added a comment - - edited

          I checked today, so I have to reopen this issue. Currently all the Tokenizer/TokenFilterFactories that require the matchVersion property in the map complain.

          In 5.0 and trunk we wanted to use Version.LATEST by default, so we should change AbstractAnalysisFactory to use this constant as default, too (instead of NULL). The assureMatchVersion call is then obsolete, because it should always be non-null.

          I will post a patch that fixes this.

          Show
          Uwe Schindler added a comment - - edited I checked today, so I have to reopen this issue. Currently all the Tokenizer/TokenFilterFactories that require the matchVersion property in the map complain. In 5.0 and trunk we wanted to use Version.LATEST by default, so we should change AbstractAnalysisFactory to use this constant as default, too (instead of NULL). The assureMatchVersion call is then obsolete, because it should always be non-null. I will post a patch that fixes this.
          Hide
          Uwe Schindler added a comment -

          Patch that fixes the remaining issues in trunk.

          Show
          Uwe Schindler added a comment - Patch that fixes the remaining issues in trunk.
          Hide
          Ryan Ernst added a comment -

          Uwe Schindler Patch looks good. Thanks!

          Show
          Ryan Ernst added a comment - Uwe Schindler Patch looks good. Thanks!
          Hide
          ASF subversion and git services added a comment -

          Commit 1651127 from Uwe Schindler in branch 'dev/trunk'
          [ https://svn.apache.org/r1651127 ]

          LUCENE-5900: Fix remaining issues with default matchVersion

          Show
          ASF subversion and git services added a comment - Commit 1651127 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1651127 ] LUCENE-5900 : Fix remaining issues with default matchVersion
          Hide
          ASF subversion and git services added a comment -

          Commit 1651128 from Uwe Schindler in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1651128 ]

          Merged revision(s) 1651127 from lucene/dev/trunk:
          LUCENE-5900: Fix remaining issues with default matchVersion

          Show
          ASF subversion and git services added a comment - Commit 1651128 from Uwe Schindler in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1651128 ] Merged revision(s) 1651127 from lucene/dev/trunk: LUCENE-5900 : Fix remaining issues with default matchVersion
          Hide
          Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          Anshum Gupta added a comment - Bulk close after 5.0 release.

            People

            • Assignee:
              Ryan Ernst
              Reporter:
              Ryan Ernst
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development