[LUCENE-5861] CachingTokenFilter should use ArrayList not LinkedList

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Fix Version/s: 5.0
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 30/Jul/14 16:47
• Updated: 28/Aug/22 14:13
• Resolved: 18/Nov/14 16:33

Description

CachingTokenFilter, to my surprise, puts each new AttributeSource.State onto a LinkedList. I think it should be an ArrayList. On large fields that get analyzed, there can be a ton of State objects to cache.

I also observe that State is itself a linked list of other State objects. Perhaps we could take this one step further and do parallel arrays of AttributeImpl, thereby bypassing State.

Issue Links

• is duplicated by: LUCENE-6033 Add CachingTokenFilter.isCached and switch LinkedList to ArrayList