Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5850

Constants#LUCENE_MAIN_VERSION can have broken values

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 4.3.1, 4.5.1
    • 4.10, 6.0
    • general/build
    • None
    • New

    Description

      Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should not contain minor versions. Well this is at least what I thought and to my knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we broke this such that the version from SegmentsInfo can not be parsed with Version#parseLeniently. IMO we should really add an assertion that this constant doesn't throw an error and / or make the smoketester catch this. to me this is actually a index BWC break. Note that 4.8.1 doesn't have this problem...

      Attachments

        1. LUCENE-5850_bomb.patch
          3 kB
          Robert Muir
        2. LUCENE-5850_smoketester.patch
          1 kB
          Robert Muir
        3. LUCENE-5850.patch
          2 kB
          Michael McCandless
        4. LUCENE-5850.patch
          13 kB
          Uwe Schindler
        5. LUCENE-5850.patch
          14 kB
          Uwe Schindler
        6. LUCENE-5850.patch
          15 kB
          Uwe Schindler
        7. LUCENE-5850.patch
          16 kB
          Uwe Schindler
        8. LUCENE-5850.patch
          17 kB
          Uwe Schindler
        9. LUCENE-5850.patch
          96 kB
          Ryan Ernst
        10. LUCENE-5850.patch
          97 kB
          Ryan Ernst
        11. LUCENE-5850.patch
          97 kB
          Ryan Ernst
        12. LUCENE-5860_hashcode.patch
          2 kB
          Simon Willnauer
        13. LUCENE-5850_hashcode.patch
          2 kB
          Simon Willnauer

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. SOLR-6389 spec version not being set correctly in solr.war

          • Blocker - Blocks development and/or testing work, production could not run
          • Resolved
          duplicates

          Bug - A problem which impairs or prevents the functions of the product. LUCENE-5537 Fix version check in TestCheckIndexes

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed

          Activity

            People

              rjernst Ryan Ernst
              simonw Simon Willnauer
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: