Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-5850

Constants#LUCENE_MAIN_VERSION can have broken values

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.3.1, 4.5.1
    • Fix Version/s: 4.10, 6.0
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should not contain minor versions. Well this is at least what I thought and to my knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we broke this such that the version from SegmentsInfo can not be parsed with Version#parseLeniently. IMO we should really add an assertion that this constant doesn't throw an error and / or make the smoketester catch this. to me this is actually a index BWC break. Note that 4.8.1 doesn't have this problem...

        Attachments

        1. LUCENE-5850_bomb.patch
          3 kB
          Robert Muir
        2. LUCENE-5850_hashcode.patch
          2 kB
          Simon Willnauer
        3. LUCENE-5850_smoketester.patch
          1 kB
          Robert Muir
        4. LUCENE-5850.patch
          97 kB
          Ryan Ernst
        5. LUCENE-5850.patch
          97 kB
          Ryan Ernst
        6. LUCENE-5850.patch
          96 kB
          Ryan Ernst
        7. LUCENE-5850.patch
          17 kB
          Uwe Schindler
        8. LUCENE-5850.patch
          16 kB
          Uwe Schindler
        9. LUCENE-5850.patch
          15 kB
          Uwe Schindler
        10. LUCENE-5850.patch
          14 kB
          Uwe Schindler
        11. LUCENE-5850.patch
          13 kB
          Uwe Schindler
        12. LUCENE-5850.patch
          2 kB
          Michael McCandless
        13. LUCENE-5860_hashcode.patch
          2 kB
          Simon Willnauer

        Issue Links

          Activity

            People

            • Assignee:
              rjernst Ryan Ernst
              Reporter:
              simonw Simon Willnauer

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment