Michael McCandless Truth be told I haven't looked at it yet. Kind of waiting for the 4.10.4 tag to be set before getting too far into this.
Of the 4 suggester-related things I marked for putting in 4.10.5, this is the one I could be most easily convinced to leave out. I'll look a bit more deeply, but I'll almost certainly defer to your expertise here.
The other three JIRAs are either very low-risk (the bit about requiring weightField in solrconfig.xml configuration) or make using the Suggester stuff from Solr unworkable for a large corpus, so I'm willing to argue about those. This one kind of snuck in there by chance though.
At least with Jan's work, we have a viable alternative for people on 4.x that MUST have this functionality, "apply the patch and go". And if that isn't possible, construct the field up-front so it's not multiValued.
Hmmm, I'm pretty much convincing myself to not put this in 4.10.5. Although I'll go for trunk and 5x.
Thanks! It's always great to have an informed viewpoint!