Lucene - Core
  1. Lucene - Core
  2. LUCENE-5825

Allowing the benchmarking algorithm to choose PostingsFormat

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 4.10, 6.0
    • Component/s: modules/benchmark
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The algorithm file for benchmarking should allow PostingsFormat to be configurable.

      1. LUCENE-5825.patch
        4 kB
        David Smiley
      2. LUCENE-5825.patch
        7 kB
        Varun V Shenoy

        Activity

        Hide
        Varun V Shenoy added a comment -

        Supports configurable Postings Format through "codec.postingsFormat" alg parameter

        Show
        Varun V Shenoy added a comment - Supports configurable Postings Format through "codec.postingsFormat" alg parameter
        Hide
        David Smiley added a comment -

        Hi Varun. Since I know we've been collaborating on GitHub, can you create a branch, apply the change (both of which you probably have already) and send a pull request upstream referencing this issue ID in the title? For some odd reason I can't apply your patch but it's not clear it's a problem with the patch or user-error on my part. FYI when patches are attached to issues, they are named "LUCENE-5825 optionalcomment.patch"

        Show
        David Smiley added a comment - Hi Varun. Since I know we've been collaborating on GitHub, can you create a branch, apply the change (both of which you probably have already) and send a pull request upstream referencing this issue ID in the title? For some odd reason I can't apply your patch but it's not clear it's a problem with the patch or user-error on my part. FYI when patches are attached to issues, they are named " LUCENE-5825 optionalcomment.patch"
        Hide
        Varun V Shenoy added a comment -

        I have pushed my branch upstream and also sent a pull request.

        The url for my branch
        https://github.com/shenoyvvarun/lucene-solr/tree/lucene-5825

        Show
        Varun V Shenoy added a comment - I have pushed my branch upstream and also sent a pull request. The url for my branch https://github.com/shenoyvvarun/lucene-solr/tree/lucene-5825
        Hide
        ASF GitHub Bot added a comment -

        Github user dsmiley commented on the pull request:

        https://github.com/apache/lucene-solr/pull/65#issuecomment-49698795

        Awesome. Please create a patch and attach the the JIRA issue (and name the patch as I indicated in the comments of the JIRA issue). And please share the git command-line you use to do it; I'm curious.

        Show
        ASF GitHub Bot added a comment - Github user dsmiley commented on the pull request: https://github.com/apache/lucene-solr/pull/65#issuecomment-49698795 Awesome. Please create a patch and attach the the JIRA issue (and name the patch as I indicated in the comments of the JIRA issue). And please share the git command-line you use to do it; I'm curious.
        Hide
        Varun V Shenoy added a comment -

        I have attached the patch and the command line I had used for creating the patch earlier was "git diff trunk lucene-5825". For the patch that I uploaded now, has been created using the command "git format-patch trunk --stdout > patchFile"

        Show
        Varun V Shenoy added a comment - I have attached the patch and the command line I had used for creating the patch earlier was "git diff trunk lucene-5825". For the patch that I uploaded now, has been created using the command "git format-patch trunk --stdout > patchFile"
        Hide
        David Smiley added a comment -

        I think the earlier patch was probably generated OK. The new one you posted is definitely wrong as it only includes your last commit – most likely because you've been merging trunk into your branch (please don't do that next time). I generated a diff this way:
        git diff --no-prefix --no-color origin/trunk...shenoy/lucene-5825 – lucene/benchmark/ > LUCENE-5825.patch

        • --no-prefix: chops off the a/ & b/ git does by default on the paths.
        • --no-color when I redirected stdout to a file it included the color codes which rendered the file corrupt. I don't remember having to set this in the past, but whatever.
        • -- lucene/benchmark: I think because you merged trunk, it included stuff outside of the benchmark module, so this filtered it.

        IntelliJ at least applied this patch fine.

        I'll commit in a sec.

        Show
        David Smiley added a comment - I think the earlier patch was probably generated OK. The new one you posted is definitely wrong as it only includes your last commit – most likely because you've been merging trunk into your branch (please don't do that next time). I generated a diff this way: git diff --no-prefix --no-color origin/trunk...shenoy/lucene-5825 – lucene/benchmark/ > LUCENE-5825 .patch --no-prefix: chops off the a/ & b/ git does by default on the paths. --no-color when I redirected stdout to a file it included the color codes which rendered the file corrupt. I don't remember having to set this in the past, but whatever. -- lucene/benchmark: I think because you merged trunk, it included stuff outside of the benchmark module, so this filtered it. IntelliJ at least applied this patch fine. I'll commit in a sec.
        Hide
        ASF subversion and git services added a comment -

        Commit 1612765 from David Smiley in branch 'dev/trunk'
        [ https://svn.apache.org/r1612765 ]

        LUCENE-5825: new benchmark codec.postingsFormat option

        Show
        ASF subversion and git services added a comment - Commit 1612765 from David Smiley in branch 'dev/trunk' [ https://svn.apache.org/r1612765 ] LUCENE-5825 : new benchmark codec.postingsFormat option
        Hide
        ASF subversion and git services added a comment -

        Commit 1612766 from David Smiley in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1612766 ]

        LUCENE-5825: new benchmark codec.postingsFormat option

        Show
        ASF subversion and git services added a comment - Commit 1612766 from David Smiley in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1612766 ] LUCENE-5825 : new benchmark codec.postingsFormat option

          People

          • Assignee:
            David Smiley
            Reporter:
            Varun V Shenoy
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development