Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      While trying to use the new Suggester in Solr I realized that SuggestStopFilter did not have a factory. We should add one.

      1. LUCENE-5820.patch
        16 kB
        Varun Thacker
      2. LUCENE-5820.patch
        16 kB
        Varun Thacker
      3. LUCENE-5820.patch
        15 kB
        Varun Thacker
      4. LUCENE-5820.patch
        34 kB
        Varun Thacker

        Issue Links

          Activity

          Hide
          Varun Thacker added a comment -

          Patch which copies the behaviour and test from StopFilterFactory to work with SuggestStopFilter.
          I also moved SuggestStopFilter to the analysis package. Let me know if this is unnecessary.

          Show
          Varun Thacker added a comment - Patch which copies the behaviour and test from StopFilterFactory to work with SuggestStopFilter. I also moved SuggestStopFilter to the analysis package. Let me know if this is unnecessary.
          Hide
          Varun Thacker added a comment -

          New patch where I didn't mess around with the package.

          Show
          Varun Thacker added a comment - New patch where I didn't mess around with the package.
          Hide
          Varun Thacker added a comment -

          New patch. Previous patch used BaseTokenStreamFactoryTestCase which can't be used. The test passed with the IDE but not with ant. This patch fixes it.

          Show
          Varun Thacker added a comment - New patch. Previous patch used BaseTokenStreamFactoryTestCase which can't be used. The test passed with the IDE but not with ant. This patch fixes it.
          Hide
          Steve Rowe added a comment -

          Varun, your patch looks good.

          A few things that should be changed:

          • Add license text to org.apache.lucene.search.suggest.analyzing.SuggestStopFilterFactory
          • Remove version handling (luceneMatchVersion) from the factory ctor and the test class (this is the only version of the filter, no need for version-specific behavior).
          • Remove unused imports - I noticed some in the test class.
          Show
          Steve Rowe added a comment - Varun, your patch looks good. A few things that should be changed: Add license text to org.apache.lucene.search.suggest.analyzing.SuggestStopFilterFactory Remove version handling ( luceneMatchVersion ) from the factory ctor and the test class (this is the only version of the filter, no need for version-specific behavior). Remove unused imports - I noticed some in the test class.
          Hide
          Varun Thacker added a comment -

          Hi Steve,

          Thanks for your feedback. Attaching a patch which fixes the changes that you mentioned.

          Show
          Varun Thacker added a comment - Hi Steve, Thanks for your feedback. Attaching a patch which fixes the changes that you mentioned.
          Hide
          Steve Rowe added a comment -

          Looks good, thanks Varun.

          Committing shortly.

          Show
          Steve Rowe added a comment - Looks good, thanks Varun. Committing shortly.
          Hide
          ASF subversion and git services added a comment -

          Commit 1625193 from Use account "steve_rowe" instead in branch 'dev/trunk'
          [ https://svn.apache.org/r1625193 ]

          LUCENE-5820: SuggestStopFilter should have a factory

          Show
          ASF subversion and git services added a comment - Commit 1625193 from Use account "steve_rowe" instead in branch 'dev/trunk' [ https://svn.apache.org/r1625193 ] LUCENE-5820 : SuggestStopFilter should have a factory
          Hide
          ASF subversion and git services added a comment -

          Commit 1625194 from Use account "steve_rowe" instead in branch 'dev/trunk'
          [ https://svn.apache.org/r1625194 ]

          LUCENE-5820: eol style

          Show
          ASF subversion and git services added a comment - Commit 1625194 from Use account "steve_rowe" instead in branch 'dev/trunk' [ https://svn.apache.org/r1625194 ] LUCENE-5820 : eol style
          Hide
          ASF subversion and git services added a comment -

          Commit 1625197 from Use account "steve_rowe" instead in branch 'dev/trunk'
          [ https://svn.apache.org/r1625197 ]

          LUCENE-5820: license exception + javadocs

          Show
          ASF subversion and git services added a comment - Commit 1625197 from Use account "steve_rowe" instead in branch 'dev/trunk' [ https://svn.apache.org/r1625197 ] LUCENE-5820 : license exception + javadocs
          Hide
          ASF subversion and git services added a comment -

          Commit 1625200 from Use account "steve_rowe" instead in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1625200 ]

          LUCENE-5820: SuggestStopFilter should have a factory (merged trunk r1625193, r1625194, and r1625197)

          Show
          ASF subversion and git services added a comment - Commit 1625200 from Use account "steve_rowe" instead in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1625200 ] LUCENE-5820 : SuggestStopFilter should have a factory (merged trunk r1625193, r1625194, and r1625197)
          Hide
          Steve Rowe added a comment -

          Committed to trunk and branch_4x.

          Thanks Varun!

          Show
          Steve Rowe added a comment - Committed to trunk and branch_4x. Thanks Varun!
          Hide
          Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          Anshum Gupta added a comment - Bulk close after 5.0 release.

            People

            • Assignee:
              Steve Rowe
              Reporter:
              Varun Thacker
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development